Bug 134378 (IT_50816) - pcmcia init script calls modprobe with '.o' appended to module names
Summary: pcmcia init script calls modprobe with '.o' appended to module names
Alias: IT_50816
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: kernel-pcmcia-cs   
(Show other bugs)
Version: 3.0
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Pete Zaitcev
QA Contact: Brian Brock
Whiteboard: RHEL3U7NAK
Depends On:
Blocks: 170417
TreeView+ depends on / blocked
Reported: 2004-10-01 19:53 UTC by David Lehman
Modified: 2007-11-30 22:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-08-02 20:59:57 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
patch to /etc/init.d/pcmcia for correct modprobe/insmod usage (811 bytes, patch)
2004-10-01 19:56 UTC, David Lehman
no flags Details | Diff

Description David Lehman 2004-10-01 19:53:46 UTC
Description of problem:
/etc/init.d/pcmcia calls 'modprobe pcmcia_core.o' instead of 'modprobe
pcmcia_core', which breaks.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. install some pcmcia modules into /lib/modules/`uname -r`/pcmcia/
2. reboot
Actual results:
Bunch of "pcmcia: modprobe: Can't locate module" errors

Expected results:
successfully finds and loads the modules

Additional info:
This has been fixed in RHL/FC track, just needs merging into RHEL3.
Here are the previous bugs:

Comment 1 David Lehman 2004-10-01 19:56:19 UTC
Created attachment 104646 [details]
patch to /etc/init.d/pcmcia for correct modprobe/insmod usage

Comment 2 Matthew Booth 2004-10-29 10:29:10 UTC
In case any context is needed, this code path is only executed when
/lib/modules/`uname -r`/pcmcia exists, which it doesn't for kernels
installed via rpm. However, it does exist for kernels compiled from
the kernel-source rpm. The other code path is fixed.

Comment 3 Eric Paris 2004-11-23 15:09:19 UTC
You say the other path is fixed, but can we not also get it fixed in
case people do compile their own kernel?  I know they would be
unsupported, but they should have the freedom to do so.

Comment 4 Pete Zaitcev 2005-06-28 18:28:09 UTC
The bug comes from Arjan's fix:

* Tue Nov 26 2002 Arjan van de Ven <arjanv@redhat.com>
- exclude range for Radeon ICP chipsets
- use modprobe not insmod

--- pcmcia-cs-3.1.31/etc/rc.pcmcia~	2002-11-26 16:46:12.000000000 +0100
+++ pcmcia-cs-3.1.31/etc/rc.pcmcia	2002-11-26 16:46:12.000000000 +0100
@@ -104,9 +104,9 @@
 	    KD=/lib/modules/`uname -r`/kernel/drivers/pcmcia
 	    if [ -d $PC ] ; then
 		echo -n " modules"
-		/sbin/insmod $PC/pcmcia_core.o $CORE_OPTS
-		/sbin/insmod $PC/$PCIC.o $PCIC_OPTS
-		/sbin/insmod $PC/ds.o
+		/sbin/modprobe pcmcia_core.o $CORE_OPTS
+		/sbin/modprobe $PCIC.o $PCIC_OPTS
+		/sbin/modprobe ds.o
 	    elif [ -d $KD ] ; then
 		/sbin/modprobe pcmcia_core
 		/sbin/modprobe $PCIC

Arjan, what's up with that? This is obviously bogus. Whatever that was
supposed to fix, it never worked right. May I back it out?

Comment 5 Arjan van de Ven 2005-06-28 18:31:35 UTC
backing out is the wrong thing, the reason the original code was wrong is that
the modules changed location between 2.2 and 2.4 kernels, and this code assumed
the 2.2 location (well technically it assumes the location pcmcia-cs puts it's
OWN modules, while we want the kernel ones).

right fix is to drop the .o 

Comment 6 Eric Paris 2005-08-11 14:48:09 UTC
This appears to have been fixed in CVS in version

This is a small bug that will not hit default installs but would affect people
who build their own modules or kernels.  The customer ticket has been open a
long time and they have verified that this would fix the problem.  Deffinitly
not a high priority, but obviously broken and already fiked in RHEL3 CVS

Note You need to log in before you can comment on or make changes to this bug.