Bug 1343901 - Fix websocket proxy for python-websockify 0.8.0
Summary: Fix websocket proxy for python-websockify 0.8.0
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: WebSocket Proxy
Version: 3.6.3.3
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ovirt-4.0.0-rc
: 4.0.0
Assignee: Vinzenz Feenstra [evilissimo]
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-08 09:38 UTC by Vinzenz Feenstra [evilissimo]
Modified: 2016-08-12 14:06 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: python-websockify in version 0.8.0 broke the API Consequence: The ovirt websocket proxy stops working Fix: We added a workaround to the websocketproxy code to detect this API breakage and handle it accordingly Result: ovirt websocket proxy is functional with python-websockify 0.6.0 and 0.8.0
Clone Of:
Environment:
Last Closed: 2016-08-12 14:06:35 UTC
oVirt Team: Virt
michal.skrivanek: ovirt-4.0.0?
rule-engine: planning_ack+
michal.skrivanek: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 58830 0 master MERGED Fix python-websockify API breakage between 0.6.0 and 0.8.0 2016-06-08 13:53:12 UTC
oVirt gerrit 58865 0 ovirt-engine-4.0 MERGED Fix python-websockify API breakage between 0.6.0 and 0.8.0 2016-06-08 15:03:04 UTC

Description Vinzenz Feenstra [evilissimo] 2016-06-08 09:38:40 UTC 
Description of problem:

The upgrade of python-websockify 0.8.0 has broken the API

ovirt websocket proxy should keep working with python-websockify 0.6.0 and 0.8.0
Comment 1 Michal Skrivanek 2016-06-08 10:29:51 UTC 
targeting 4.0 GA just because websocket update is already available in centos and you would have to explicitly downgrade that package to make proxy work
Comment 2 Martin Perina 2016-06-10 14:58:44 UTC 
Setting target release to 4.0.0 as it's included in today's 4.0.4 build
Comment 3 sefi litmanovich 2016-08-08 09:12:31 UTC 
Verified with rhevm-4.0.2.4-0.1.el7ev.noarch, and websocket proxy installed on engine host with version: python-websockify-0.8.0-1.el7.noarch

Started a console with noVnc, worked fine as expected.
Note You need to log in before you can comment on or make changes to this bug.