Bug 1344044 - Floating IPs have no displayed names in Grid View
Summary: Floating IPs have no displayed names in Grid View
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.0
Assignee: Eric Hayes
QA Contact: Matouš Mojžíš
URL:
Whiteboard: ui
Depends On:
Blocks: 1349626
TreeView+ depends on / blocked
 
Reported: 2016-06-08 15:18 UTC by Matouš Mojžíš
Modified: 2017-01-12 05:07 UTC (History)
6 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1349626 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:25:47 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
floating ips with no name (59.96 KB, image/png)
2016-06-08 15:18 UTC, Matouš Mojžíš
no flags Details

Description Matouš Mojžíš 2016-06-08 15:18:47 UTC
Created attachment 1166049 [details]
floating ips with no name

Description of problem:


Version-Release number of selected component (if applicable):
5.6.0.10

How reproducible:
Always

Steps to Reproduce:
1. Add a cloud provider, which has floating IPs
2. Network -> Floating IPs
3. Change view to grid

Actual results:
Names not displayed

Expected results:
Names(IP numbers) should be displayed

Additional info:
screenshot attached

Comment 2 Harpreet Kataria 2016-06-14 21:06:51 UTC
Eric,

since floating IP records do not have name, we should use address column to display as text on grid/tile view screens. We do something similar for couple of other CIs that do not have name columns, Take a look at 
https://github.com/ManageIQ/manageiq/blob/master/app/helpers/quadicon_helper.rb#L81 
https://github.com/ManageIQ/manageiq/blob/master/app/helpers/quadicon_helper.rb#L117
let me know if you need further help with looking into that method or have questions.

Thanks,
~Harpreet.

Comment 3 Eric Hayes 2016-06-16 14:52:22 UTC
Fixed here: https://github.com/ManageIQ/manageiq/pull/9237

Comment 6 Matouš Mojžíš 2016-09-30 13:34:31 UTC
Verified in 5.7.0.3. Floating IPs in grid view have their address displayed.


Note You need to log in before you can comment on or make changes to this bug.