Bug 1344080 - Creating provisioning dialog with no type chosen(default used named Choose)
Summary: Creating provisioning dialog with no type chosen(default used named Choose)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.0
Assignee: Brian McLaughlin
QA Contact: Shveta
URL:
Whiteboard: ui:dialog
Depends On:
Blocks: 1349625
TreeView+ depends on / blocked
 
Reported: 2016-06-08 17:10 UTC by Matouš Mojžíš
Modified: 2017-01-12 04:57 UTC (History)
7 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1349625 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:07:40 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Matouš Mojžíš 2016-06-08 17:10:27 UTC
Description of problem:


Version-Release number of selected component (if applicable):
5.6.0.10

How reproducible:
Always

Steps to Reproduce:
1. Automate -> Customization
2. Add a new dialog
3. Don't change type, keep it default

Actual results:
It allows to create dialog without changing choose.
Dialog is listed in all dialogs, but is unclickable and is not listed in left tree view.

Expected results:
Do not let create dialog without chosing the type.

Additional info:

Comment 3 CFME Bot 2016-06-21 21:46:16 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/f2f1950f686704b22b3ec7ab778ca1d058fe7b51

commit f2f1950f686704b22b3ec7ab778ca1d058fe7b51
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Mon Jun 20 15:46:49 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Tue Jun 21 14:02:17 2016 -0400

    Require Dialog Type when creating a new Dialog
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1344080

 .../miq_ae_customization_controller/old_dialogs.rb |  2 +-
 .../old_dialogs_spec.rb                            | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)

Comment 4 CFME Bot 2016-06-21 21:46:21 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/3708580a52a065f2926c828c531734af0149c441

commit 3708580a52a065f2926c828c531734af0149c441
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Tue Jun 21 13:23:24 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Tue Jun 21 14:02:17 2016 -0400

    Refactor to improve performance
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1344080

 app/controllers/miq_ae_customization_controller/old_dialogs.rb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comment 5 CFME Bot 2016-06-21 21:46:25 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/f02c45f557841962e1f0fba660cb2b86b0372402

commit f02c45f557841962e1f0fba660cb2b86b0372402
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Mon Jun 20 16:52:35 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Tue Jun 21 14:02:17 2016 -0400

    Fix style errors
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1344080

 .../miq_ae_customization_controller/old_dialogs_spec.rb       | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Comment 7 Shveta 2016-09-21 19:10:27 UTC
Fixed.
Verified in 5.7.0.0.20160906172503_12f65cb


Note You need to log in before you can comment on or make changes to this bug.