Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/hoedown.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/hoedown-3.0.7-1.fc24.src.rpm Description: Hoedown is a revived fork of Sundown, the Markdown parser based on the original code of the Upskirt library by Natacha Porté. Features: * Fully standards compliant * Massive extension support * UTF-8 aware * Tested & Ready to be used on production * Customizable renderers * Optimized for speed * Zero-dependency Fedora Account System Username: ignatenkobrain
Preliminary review: - Shouldn't the library go in a separate subpackage? The executables won't be needed for library users. I'd expect one of these layouts: - hoedown, hoedown-libs, hoedown-devel - hoedown, libhoedown, libhoedown-devel - The library needs %post/%postun ldconfig
(In reply to Josh Stone from comment #1) > Preliminary review: > > - Shouldn't the library go in a separate subpackage? The executables won't > be needed for library users. I'd expect one of these layouts: > - hoedown, hoedown-libs, hoedown-devel > - hoedown, libhoedown, libhoedown-devel hm, there is only 2 binaries with small size. is it worth to make libs subpackage? > > - The library needs %post/%postun ldconfig ah yes, forgot about it. Will add it. Anything else to fix?
> hm, there is only 2 binaries with small size. is it worth to make libs subpackage? I can't find official guidelines on this, but I prefer to avoid installing things in /bin unnecessarily. If most people will be using this in library form, as with rustdoc, then they don't need the binaries. You can take python for precedent -- its main binary is even smaller than these. > Anything else to fix? Not that I see.
(In reply to Josh Stone from comment #3) > > hm, there is only 2 binaries with small size. is it worth to make libs subpackage? > > I can't find official guidelines on this, but I prefer to avoid installing > things in /bin unnecessarily. If most people will be using this in library > form, as with rustdoc, then they don't need the binaries. There are no guidelines about that, it's up to maintainer if he wants to have libs subpkg. I will make it. > > You can take python for precedent -- its main binary is even smaller than > these. > > > Anything else to fix? > > Not that I see.
Unfortunately I don't have time to work on these review requests anymore, sorry.