Created attachment 1168523 [details]
bz_1346034_2.tgz

Fix URI encoding issues in azure-armrest gem

Created attachment 1168754 [details]
bz_1346034_3.tgz

URI.escape more urls that may have invalid characters

Created attachment 1168814 [details]
bz_1346034_4.tgz

Updated again to rescue failures when trying to fetch URIs with invalid characters.

Created attachment 1169945 [details]
bz_1346034_5.tgz

Includes the recently released azure-signature v0.2.2

https://github.com/ManageIQ/manageiq/pull/9294

I was able to force this by uploading a disk, but the disk name in question cannot be created in azure under normal circumstances.  I'm not convinced our workaround is such a great idea.  That said, this bug as written is fixed.

Here is the Azure error that the user should have received which includes a list of invalid characters:

Failed to attach new disk 'RetireFrom11-20160711-{152929}' to the virtual machine 'RetireFrom11'. Error: InvalidParameter: The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\W][\w-._]{0,79}(?<![-.])$.

Jeff, I would argue that it's a bug in Azure then. I don't think there's any issue with our fix, since we're just reporting what they've got.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1488.html