Spec URL: https://mkrizek.fedorapeople.org/specs/resultsdb_frontend.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/resultsdb_frontend-1.1.9-2.fc23.src.rpm Description: Frontend for the ResultsDB FAS: mkrizek
So, first pass looks relatively sane, except as per the newer Python guidelines you should use the following macros in %build and %install: %{__python2} setup.py build -> %py2_build %{__python2} setup.py install --skip-build --root %{buildroot} -> %py2_install (see https://fedoraproject.org/wiki/Packaging:Python). It would also be good to use "python2-*" to refer to your Requires and BuildRequires where possible. Otherwise I didn't find any blockers, so if you can modernize the Python macros I'll go ahead with a full review.
Thanks! Updated version follows: Spec URL: https://mkrizek.fedorapeople.org/specs/resultsdb_frontend.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/resultsdb_frontend-1.1.9-3.fc23.src.rpm
There is one other issue (see below) that is only a SHOULD; please fix this before importing into Fedora. Otherwise, package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== * Packages should try to preserve timestamps of original installed files. mkdir -p %{buildroot}%{_datadir}/resultsdb_frontend/conf cp conf/resultsdb_frontend.conf %{buildroot}%{_datadir}/resultsdb_frontend/conf/. cp conf/resultsdb_frontend.wsgi %{buildroot}%{_datadir}/resultsdb_frontend/. mkdir -p %{buildroot}%{_sysconfdir}/resultsdb_frontend install conf/settings.py.example %{buildroot}%{_sysconfdir}/resultsdb_frontend/settings.py.example These should be "cp -p" or "install -p" to preserve the timestamps. (https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 6 files have unknown license. Detailed output of licensecheck in /home/bjr/Programming/fedora/reviews/1346245-resultsdb_frontend/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: resultsdb_frontend-1.1.9-3.fc26.noarch.rpm resultsdb_frontend-1.1.9-3.fc26.src.rpm resultsdb_frontend.noarch: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end resultsdb_frontend.noarch: E: script-without-shebang /etc/resultsdb_frontend/settings.py.example resultsdb_frontend.src: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- resultsdb_frontend.noarch: W: spelling-error Summary(en_US) Frontend -> Fronted, Front end, Front-end resultsdb_frontend.noarch: E: script-without-shebang /etc/resultsdb_frontend/settings.py.example 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Requires -------- resultsdb_frontend (rpmlib, GLIBC filtered): python(abi) python-flask python-flask-wtf python-resultsdb_api python-six python2-flask-restful python2-iso8601 Provides -------- resultsdb_frontend: python2.7dist(resultsdb-frontend) python2dist(resultsdb-frontend) resultsdb_frontend Source checksums ---------------- https://qadevel.cloud.fedoraproject.org/releases/resultsdb_frontend/resultsdb_frontend-1.1.9.tar.gz : CHECKSUM(SHA256) this package : 7a050431575a2f7c99ce944f8ebb79d0ef98a02d0705e58145a0a2402bf8a28d CHECKSUM(SHA256) upstream package : 7a050431575a2f7c99ce944f8ebb79d0ef98a02d0705e58145a0a2402bf8a28d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1346245 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/resultsdb_frontend
resultsdb_frontend-1.1.9-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-16621fdec8
resultsdb_frontend-1.1.9-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b8e61f27d9
resultsdb_frontend-1.1.9-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-10ce986b13
resultsdb_frontend-1.1.9-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
resultsdb_frontend-1.1.9-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
resultsdb_frontend-1.1.9-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.