openstackclient has added osc-lib since newton cycle in https://github.com/openstack/python-openstackclient/commit/6c269efda87185a1bbecf22c62dead1cd78132af . Spec URL: https://raw.githubusercontent.com/amoralej/python-osc-lib/master/python-osc-lib.spec SRPM URL: https://github.com/amoralej/python-osc-lib/raw/master/python-osc-lib-0.1.0-1.fc25.src.rpm Description: OpenStackClient (aka OSC) is a command-line client for OpenStack. osc-lib is a package of common support modules for writing OSC plugins. Fedora Account System Username: amoralej Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=14488871
This is my first package, so I'm adding FE-NEEDSPONSOR blocker.
In order to install the packages in a fresh system with rawhide repos enabled, i had to use following packages from latest dlrn build for rawhide: python2-oslo-utils-3.12.1-0.20160610190315.98e24be.fc25.noarch.rpm python-stevedore-1.15.0-0.20160614092141.01b09a5.fc25.noarch.rpm and for python3: python3-oslo-utils-3.12.1-0.20160610190315.98e24be.fc25.noarch.rpm python3-stevedore-1.15.0-0.20160614092141.01b09a5.fc25.noarch.rpm For requirements: python3-oslo-utils >= 3.11.0 python3-stevedore >= 1.10.0 So we'll need to update the current versions in rawhide.
While Fedora formal review continues, this can be imported to RDO Trunk rpm-master branch: licensing is good and code itself was extracted from python-openstackclient.
(In reply to Alan Pevec from comment #3) Already in progress: https://review.rdoproject.org/r/1408
This is currently blocking the update of Fedora rawhide clients to Newton.
New spec and SRPM with latest library version (1.1.0) and requirements update. Spec URL: https://raw.githubusercontent.com/amoralej/python-osc-lib/master/python-osc-lib.spec SRPM URL: https://github.com/amoralej/python-osc-lib/raw/master/python-osc-lib-1.1.0-1.fc24.src.rpm Scratch build successful in http://koji.fedoraproject.org/koji/taskinfo?taskID=15600094
New package release 1.1.0-2 adding upstream_version and fallback macro. Spec URL: https://raw.githubusercontent.com/amoralej/python-osc-lib/master/python-osc-lib.spec SRPM URL: https://github.com/amoralej/python-osc-lib/raw/master/python-osc-lib-1.1.0-2.fc24.src.rpm Scratch build successful in http://koji.fedoraproject.org/koji/taskinfo?taskID=15601900
I hereby approve this package, please submit a pkgdb request. Please request F24+ branches. I also sponsored Alfredo in the packager group. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 10 files have unknown license. Detailed output of licensecheck in /home/haikel/1346412-python-osc-lib/python-osc- lib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. (koji scratch builds) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -osc-lib , python2-osc-lib-tests , python-osc-lib-doc , python3-osc- lib , python3-osc-lib-tests [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Installation errors ------------------- INFO: mock.py version 1.2.20 starting (python version = 3.5.1)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.20 INFO: Mock Version: 1.2.20 Finish: chroot init INFO: installing package(s): /home/haikel/1346412-python-osc-lib/python-osc-lib-doc-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python2-osc-lib-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python3-osc-lib-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python2-osc-lib-tests-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python3-osc-lib-tests-1.1.0-1.fc26.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-24-x86_64/root/ --releasever 24 --disableplugin=local --setopt=deltarpm=false install /home/haikel/1346412-python-osc-lib/python-osc-lib-doc-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python2-osc-lib-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python3-osc-lib-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python2-osc-lib-tests-1.1.0-1.fc26.noarch.rpm /home/haikel/1346412-python-osc-lib/python3-osc-lib-tests-1.1.0-1.fc26.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python2-osc-lib-1.1.0-1.fc26.noarch.rpm python2-osc-lib-tests-1.1.0-1.fc26.noarch.rpm python-osc-lib-doc-1.1.0-1.fc26.noarch.rpm python3-osc-lib-1.1.0-1.fc26.noarch.rpm python3-osc-lib-tests-1.1.0-1.fc26.noarch.rpm python-osc-lib-1.1.0-1.fc26.src.rpm python2-osc-lib.noarch: W: no-documentation python2-osc-lib-tests.noarch: W: no-documentation python3-osc-lib.noarch: W: no-documentation python3-osc-lib-tests.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- python3-osc-lib-tests (rpmlib, GLIBC filtered): python(abi) python3-osc-lib python3-osc-lib (rpmlib, GLIBC filtered): python(abi) python3-cliff python3-keystoneauth1 python3-os-client-config python3-oslo-config python3-oslo-i18n python3-oslo-utils python3-pbr python3-requests python3-simplejson python3-six python3-stevedore python2-osc-lib-tests (rpmlib, GLIBC filtered): python(abi) python2-osc-lib python-osc-lib-doc (rpmlib, GLIBC filtered): python2-osc-lib (rpmlib, GLIBC filtered): python(abi) python-cliff python-keystoneauth1 python-os-client-config python-oslo-config python-oslo-i18n python-oslo-utils python-pbr python-requests python-simplejson python-six python-stevedore Provides -------- python3-osc-lib-tests: python3-osc-lib-tests python3-osc-lib: python3-osc-lib python3.5dist(osc-lib) python3dist(osc-lib) python2-osc-lib-tests: python2-osc-lib-tests python-osc-lib-doc: python-osc-lib-doc python2-osc-lib: python-osc-lib python2-osc-lib python2.7dist(osc-lib) python2dist(osc-lib) Source checksums ---------------- http://tarballs.openstack.org/osc-lib/osc-lib-1.1.0.tar.gz : CHECKSUM(SHA256) this package : e06ca111b2702d442f5cf70c754b6331cc7742231f0fe0b634cbd03c502610ba CHECKSUM(SHA256) upstream package : e06ca111b2702d442f5cf70c754b6331cc7742231f0fe0b634cbd03c502610ba Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --rpm-spec --prebuilt --name python-osc-lib Buildroot used: fedora-24-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-osc-lib
Package successfully built for rawhide in http://koji.fedoraproject.org/koji/packageinfo?packageID=23062