Bug 1346551 - wrong understanding of function's parameter
Summary: wrong understanding of function's parameter
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: mainline
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Zhou Zhengping
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-15 01:59 UTC by Zhou Zhengping
Modified: 2017-01-03 11:24 UTC (History)
4 users (show)

Fixed In Version: 3.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-03 11:24:22 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Zhou Zhengping 2016-06-15 01:59:04 UTC 
Wrong usage of function dht_selfheal_dir_xattr_cbk in function dht_selfheal_dir_xattr_persubvol
Comment 1 Nithya Balachandran 2016-06-15 04:16:34 UTC 
Can you please elaborate on what is wrong?

Thanks,
Nithya
Comment 2 Vijay Bellur 2016-06-16 03:00:47 UTC 
REVIEW: http://review.gluster.org/14737 (Wrong type of function's parameter when calling dht_selfheal_dir_xattr_cbk, the second parameter's type should be call_frame_t * .) posted (#1) for review on master by Zhou Zhengping (johnzzpcrystal)
Comment 3 Vijay Bellur 2016-06-21 17:29:29 UTC 
REVIEW: http://review.gluster.org/14737 (cluster/dht: Wrong type of function's parameter when calling dht_selfheal_dir_xattr_cbk) posted (#2) for review on master by Zhou Zhengping (johnzzpcrystal)
Comment 4 Vijay Bellur 2016-06-21 19:46:05 UTC 
REVIEW: http://review.gluster.org/14737 (cluster/dht: Wrong type of function's parameter when calling dht_selfheal_dir_xattr_cbk) posted (#3) for review on master by Zhou Zhengping (johnzzpcrystal)
Comment 5 Vijay Bellur 2016-06-23 14:33:22 UTC 
COMMIT: http://review.gluster.org/14737 committed in master by Vijay Bellur (vbellur) 
------
commit 1fdc0db572ce80d6f3a9e71d40ef272c2eb3e7e7
Author: Zhou Zhengping <johnzzpcrystal>
Date:   Wed Jun 22 01:27:25 2016 +0800

    cluster/dht: Wrong type of function's parameter when calling dht_selfheal_dir_xattr_cbk
    
    The second parameter's type is call_frame_t *, and we change
    it to be type xlator_t *, it is exactly what we need in this function.
    
    Change-Id: I6a154edcaa5a11084d837ca925efbfac853d0786
    BUG: 1346551
    Signed-off-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-on: http://review.gluster.org/14737
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
    CentOS-regression: Gluster Build System <jenkins.org>
Note You need to log in before you can comment on or make changes to this bug.