Bug 1346677 - Review Request: perl-Data-Entropy - Entropy (randomness) management
Summary: Review Request: perl-Data-Entropy - Entropy (randomness) management
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-15 07:45 UTC by Emmanuel Seyman
Modified: 2016-06-30 08:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-06-30 08:12:42 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2016-06-15 07:45:07 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Data-Entropy/perl-Data-Entropy.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Data-Entropy/perl-Data-Entropy-0.007-1.fc25.src.rpm
Description:
This module maintains a concept of a current selection of entropy source.
Algorithms that require entropy, such as those in
Data::Entropy::Algorithms, can use the source nominated by this module,
avoiding the need for entropy source objects to be explicitly passed
around. This is convenient because usually one entropy source will be used
for an entire program run and so an explicit entropy source parameter would
rarely vary. There is also a default entropy source, avoiding the need to
explicitly configure a source at all.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2016-06-15 11:36:05 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Data-Entropy-0.007-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Crypt::Rijndael)
      1 perl(Data::Entropy)
      1 perl(Data::Float) >= 0.008
      1 perl(Errno) >= 1.00
      1 perl(Exporter)
      1 perl(HTTP::Lite) >= 2.2
      1 perl(IO::File) >= 1.03
      1 perl(Params::Classify) >= 0.000 
      1 perl(constant)
      1 perl(integer)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please add perl(Math::BigInt) to build and run-require, because it
     could be used in lib/Data/Entropy/Source.pm.

$ rpm -qp --provides perl-Data-Entropy-0.007-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Data::Entropy) = 0.007
      1 perl(Data::Entropy::Algorithms) = 0.007
      1 perl(Data::Entropy::RawSource::CryptCounter) = 0.007
      1 perl(Data::Entropy::RawSource::Local) = 0.007
      1 perl(Data::Entropy::RawSource::RandomOrg) = 0.007
      1 perl(Data::Entropy::RawSource::RandomnumbersInfo) = 0.007
      1 perl(Data::Entropy::Source) = 0.007
      1 perl-Data-Entropy = 0.007-1.fc25 
Binary provides are Ok.

$ rpmlint ./perl-Data-Entropy*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires:
  Math::BigRat is only optional for tests
FIX: Please add version to the following BRs:
  perl(Data::Float) >= 0.008 - lib/Data/Entropy/Algorithms.pm:48
  perl(Errno) >= 1.00 - lib/Data/Entropy/RawSource/RandomOrg.pm:52
  perl(HTTP::Lite) >= 2.2 - lib/Data/Entropy/RawSource/RandomOrg.pm:53
  perl(IO::File) >= 1.03 - lib/Data/Entropy/RawSource/Local.pm:50
  perl(Params::Classify) >= 0.000 - lib/Data/Entropy.pm
  perl(Test::Pod) >= 1.00 - t/pod_syn.t:5

Please correct all 'FIX' issues.

Otherwise package looks good.
Approved

Comment 2 Emmanuel Seyman 2016-06-16 05:43:00 UTC
(In reply to Jitka Plesnikova from comment #1)
>
> FIX: Please add perl(Math::BigInt) to build and run-require, because it
>      could be used in lib/Data/Entropy/Source.pm.

Done.

> FIX: Please add version to the following BRs:
>   perl(Data::Float) >= 0.008 - lib/Data/Entropy/Algorithms.pm:48
>   perl(Errno) >= 1.00 - lib/Data/Entropy/RawSource/RandomOrg.pm:52
>   perl(HTTP::Lite) >= 2.2 - lib/Data/Entropy/RawSource/RandomOrg.pm:53
>   perl(IO::File) >= 1.03 - lib/Data/Entropy/RawSource/Local.pm:50

Done.

>   perl(Params::Classify) >= 0.000 - lib/Data/Entropy.pm

This one, I think I'll ignore. :-)

>   perl(Test::Pod) >= 1.00 - t/pod_syn.t:5

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Data-Entropy/perl-Data-Entropy.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Data-Entropy/perl-Data-Entropy-0.007-2.fc25.src.rpm

Repo requested in pkgdb. Thank you for the review, Jikta.

Comment 3 Gwyn Ciesla 2016-06-16 13:06:38 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Data-Entropy


Note You need to log in before you can comment on or make changes to this bug.