Bug 1346729 - /usr/share/ovirt-engine/dbscripts/engine-psql.sh has hardcoded db name ('engine' )
Summary: /usr/share/ovirt-engine/dbscripts/engine-psql.sh has hardcoded db name ('engi...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: redhat-support-plugin-rhev
Version: 3.6.0
Hardware: All
OS: Linux
low
low
Target Milestone: ovirt-4.0.2
: ---
Assignee: Derrick Ornelas
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-15 09:06 UTC by Jiri Belka
Modified: 2016-07-28 10:30 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-28 10:30:04 UTC
oVirt Team: UX
Target Upstream Version:


Attachments (Terms of Use)

Description Jiri Belka 2016-06-15 09:06:15 UTC
Description of problem:

Not sure if having hardcoded db name is valid approach here:

# grep '^psql' /usr/share/ovirt-engine/dbscripts/engine-psql.sh                                                                                                                                  
psql -U "${USERNAME}" -h "${HOST}" -p "${port}" engine "$@" | tee -a "${LOGFILE}" 2>&1


Version-Release number of selected component (if applicable):
redhat-support-plugin-rhev-3.6.0-15.el6.noarch
redhat-support-plugin-rhev-4.0.0-4.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. check if db name is a variable or hardcoded in shell script
2.
3.

Actual results:
db name is hardcoded

Expected results:
should be variable, let's imagine remote db

Additional info:
not tested against remote db, just checking a part of the code

Comment 12 Gil Klein 2016-07-28 10:30:04 UTC
This bug was fixed and is slated to be in the upcoming version. As we
are focusing our testing at this phase on severe bugs, this bug was
closed without going through its verification step. If you think this
bug should be verified by QE, please set its severity to high and move
it back to ON_QA


Note You need to log in before you can comment on or make changes to this bug.