Bug 1347113
| Summary: | When creating a new VM disk with an IDE interface, the "Read Only" field should not be displayed at all | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Idan Shaby <ishaby> |
| Component: | Frontend.WebAdmin | Assignee: | Benny Zlotnik <bzlotnik> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Eyal Shenitzky <eshenitz> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.6.2 | CC: | amureini, bugs, ehildesh, ishaby, michal.skrivanek, tnisan |
| Target Milestone: | ovirt-4.1.0-beta | Keywords: | UserExperience |
| Target Release: | 4.1.0.2 | Flags: | rule-engine:
ovirt-4.1+
rule-engine: planning_ack+ rule-engine: devel_ack+ ratamir: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-01 14:52:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Idan Shaby
2016-06-16 05:34:41 UTC
Correct. Why are we gong back to the wrong practice of removing/hiding items rather than graying out and explaining why? Actually I explained it in the description of the BZ. I guess that Eldan can explain it better than me. (In reply to Idan Shaby from comment #3) > Actually I explained it in the description of the BZ. > I guess that Eldan can explain it better than me. Description says it's greyed out. Which is correct and similar to waht we are doing everywhere else. Instead of adding/removing entities which create confusion we just grey out things which are not applicable/disabled for a particular case, like a specific interface not supporting r/o Why everywhere? Create a new VM disk, select direct lun, switch between IDE and VirtIO-SCSI and you'll see both strategies in one place. Who said it's the right behavior? I talked to Eldan and he told me that the read only behavior is misleading and that we should fix it, so I opened this bug. He explained to me that the behavior depends on the specific window, it's not that we should always go this way or the another. I don't mind to close this BZ as WONT_FIX/NOT_A_BUG, but please talk to Eldan and get to an understanding about this. Eldan is the subject matter expert here. Eldan - your call please? Maybe I'm seeing a different thing or I'm still not looking at the right place, but when I try the above in 4.0 I see following behavior in both Image and Direct LUN windows: virtio - read only selectable virtio-scsi - for Images it is selectable, for LUN it's greyed out with an explanation why it can't be set RO IDE - greyed out with explanation why it can't be checked looks consistent to me. Eldan? I'm sorry, I didn't explain myself right. When I said that "you'll see both strategies in one place" I didn't mean that you should look on the read only checkbox, but at the behavior of all of the right part of the window: 1. When you switch to VirtIO-SCSI from any other interface you get three new checkboxes. 2. Yet, the SCSI reservation checkbox is greyed out and will be available only if you tick the "Allow Privileged.." checkbox. This is what I meant when I said "the behavior depends on the specific window, it's not that we should always go this way or the another". From what I've understood from Eldan, this is the right behavior for this flow, and the read only checkbox should behave like number 1. Still, talk to Eldan. If a feature is not relevant to a specific object - don't show it! By showing it, you give the user the impression the feature might be relevant to the object. Example in oVirt: Go to new Network Tab, toggle the 'Create on external provider'. A new left tab has been added - Subnet. Subnet is not relevant when 'Create on external provider' is off, so we don't show it. Sorry, but that is against the past ~2 years of changes As for the example, I'm not sure it works correctly, at least in 4.0 it behaves in a weird way: - there is "Export" label which doesn't make much sense - when create on ext provider checked the drop down contains an empty checked value when there is no provider. What does it mean? - rest of General subtab is greyed out except for VLAN tagging - bug or intended? - a new subtab Subnet appears with another checkbox "create subnet", when not checked everything is greyed out except DNS Servers where you can enter text but not + or -. Illogical So I would take this as an example of a correct behavior at all. Even ignoring the issues - here it's a different matter this bug is not about a new subtab AFAIU but a single checbox in a column of another checkboxes always present. Please correct me if I misunderstood the intended change in this bug. Lets take it offline cause as far as we understand you: all the things that you wrote - justify what we are saying. Verified with the following code: ---------------------------------- rhevm-4.1.0-0.4.master.20170104181027.gitab0e3f4.el7.centos Verified with the following scenario: ------------------------------------------ 1. Create a VM. 2. Go to the "Disks" sub tab. 3. Click on "New". 4. Change the interface to "IDE". Moving to VERIFIED |