Bug 1347162 - UX: Automate - Configuration button is not present in read-only domains until there is a writeable domain available
Summary: UX: Automate - Configuration button is not present in read-only domains until...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: cfme-future
Assignee: Eric Hayes
QA Contact: Matouš Mojžíš
URL:
Whiteboard: ui:ux:automate
Depends On:
Blocks: 1353294
TreeView+ depends on / blocked
 
Reported: 2016-06-16 08:10 UTC by Jan Krocil
Modified: 2017-08-21 13:04 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1353294 (view as bug list)
Environment:
Last Closed: 2017-08-21 13:04:46 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jan Krocil 2016-06-16 08:10:44 UTC
Description of problem:
SSIA

Version-Release number of selected component (if applicable):
5.6.0.10

How reproducible:
Always

Steps to Reproduce:
1. Automate, navigate to an existing read-only domain (with no custom domains available)
2. Navigate to a class / method you want to copy

Actual results:
No toolbar buttons available (Cofiguration button missing).

Expected results:
I believe having a disabled button with a tooltip explaining why the button is disabled (e.g. No writeable domains available, create one first) is preferred over simply hiding the button.

Additional info:

Comment 3 Harpreet Kataria 2016-06-24 16:16:16 UTC
Let's remove code here that hides toolbar buttons when domain is locked: https://github.com/ManageIQ/manageiq/blob/master/app/helpers/application_helper/toolbar_builder.rb#L717-L718

update code in this area to disable buttons when domain is locked and display appropriate hover text on the buttons https://github.com/ManageIQ/manageiq/blob/master/app/helpers/application_helper/toolbar_builder.rb#L1122

~Harpreet

Comment 5 CFME Bot 2016-07-05 20:57:04 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/9acf1cbb3e04aff08a39275522c806b24316a231

commit 9acf1cbb3e04aff08a39275522c806b24316a231
Author:     Eric Hayes <eric>
AuthorDate: Fri Jun 24 16:28:40 2016 -0700
Commit:     Eric Hayes <eric>
CommitDate: Fri Jul 1 13:43:41 2016 -0700

    Show the configure drop-down with some guidance when no enabled or unlocked domains exist.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1347162

 app/helpers/application_helper/toolbar_builder.rb  | 16 +++-
 lib/miq_automation_engine/models/miq_ae_domain.rb  |  4 +
 .../application_helper/toolbar_builder_spec.rb     | 88 +++++++++++++++++++++-
 3 files changed, 106 insertions(+), 2 deletions(-)

Comment 8 Chris Pelland 2017-08-21 13:04:46 UTC
This bug has been open for more than a year and is assigned to an older release of CloudForms. 

If you would like to keep this Bugzilla open and if the issue is still present in the latest version of the product, please file a new Bugzilla which will be added and assigned to the latest release of CloudForms.


Note You need to log in before you can comment on or make changes to this bug.