Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1347239

Summary:	[Beaker] A system can be set to Automated but not associated to any lab controller.
Product:	[Retired] Beaker	Reporter:	Jeff Burke <jburke>
Component:	web UI	Assignee:	Roman Joost <rjoost>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	22	CC:	dcallagh, dgilbert, dowang, mjia, rjoost
Target Milestone:	23.3	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://beaker.engineering.redhat.com/view/intel-e31225-8-3.englab.nay.redhat.com#scheduler-settings
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-07 06:44:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Comment 1 Roman Joost 2016-07-14 03:08:14 UTC

It seems the underlying issue here is that the systems have ended up in Automated while the lab controller was removed. This means instead of keeping the systems in 'Automated' it would be better to change them to Broken, to avoid confusion for users.

Comment 2 Roman Joost 2016-07-14 05:44:29 UTC

Patch available:

https://gerrit.beaker-project.org/#/c/5064

Comment 3 Roman Joost 2016-08-05 00:30:32 UTC

Dumping my thoughts on the progress to fix this bug.

So it turns out that setting all machines connected to the lab controller broken is currently done by a bulk update operation. The problem with that is that it does not update the SystemStatusDuration leading to an invalid state:

https://beaker-project.org/jenkins-results/beaker-review-checks-dogfood-RedHatEnterpriseLinux6/511/beaker/J%3a10275/344665-test_log--distribution-beaker-dogfood-tests.log
(e.g. last test failure)

The problem is reproducable by running two test cases like:

./run-tests.sh bkr.inttest.server.selenium.test_labcontrollers:LabControllerViewTest bkr.inttest.server.test_beakerd:TestBeakerdMetrics.test_dirty_job_metrics -xs

Next things todo:

* Dan mentioned that the code which currently performs a bulk update (see labcontroller.py:74) operation was put in place because doing this in Python code will probably perform very badly if e.g. we set 2000 machines to broken. I'll have to see if I can find a bug describing a problen in regards to a BOS labcontroller decommissioned and the fallout of that.

* Check since the last time, we could now perform the update in Python without a big performance impact.

Comment 6 Dan Callaghan 2016-11-07 06:44:42 UTC

Beaker 23.3 has been released.