Created attachment 1168698 [details] screen shot of Datastore bottleneck page Description of problem: ----------------------- Host events are not relevant to datastores and hence the 'Show host events' check box is not needed on datastore bottleneck page. Version-Release number of selected component (if applicable): ---------------------- 5.6.0.10 How reproducible: ----------------- Always Steps to Reproduce: ------------------ 1. 2. 3. Actual results: -------------- Expected results: ----------------- Additional info: ----------------
Brian, Following is the output of where_clause when Datastore is selected in the tree hosts unchecked (((resource_type = 'Storage' AND resource_id = 1000000000024)) AND (event_type in ('DiskUsage','CpuUsage','MemoryUsage'))) AND resource_type != 'Host' hosts checked ((resource_type = 'Storage' AND resource_id = 1000000000024)) AND (event_type in ('DiskUsage','CpuUsage','MemoryUsage')) We should remove the "Show Host Events" check box from UI when datastore is selected in the tree, and also change the code that builds where clause to not append " AND resource_type != 'Host'" to where_clause for Datastore nodes. Let me know if you have questions. Thanks, ~Harpreet.
https://github.com/ManageIQ/manageiq/pull/9464
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/43ad68e7cdd13752c9a33168e7b51bc452c206e4 commit 43ad68e7cdd13752c9a33168e7b51bc452c206e4 Author: Brian McLaughlin <bmclaugh> AuthorDate: Mon Jun 27 15:30:10 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Mon Jun 27 15:30:10 2016 -0400 Remove Show Hosts Events checkbox on datastore bottleneck page https://bugzilla.redhat.com/show_bug.cgi?id=1347248 app/controllers/miq_capacity_controller.rb | 3 ++- app/views/miq_capacity/_bottlenecks_options.html.haml | 2 +- .../miq_capacity/_bottlenecks_options.html.haml_spec.rb | 13 +++++++++++++ 3 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 spec/views/miq_capacity/_bottlenecks_options.html.haml_spec.rb
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/95a7f96afbbd150a4372267764a353dbdbcdec13 commit 95a7f96afbbd150a4372267764a353dbdbcdec13 Author: Brian McLaughlin <bmclaugh> AuthorDate: Mon Jun 27 16:39:44 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Mon Jun 27 16:39:44 2016 -0400 Refactor spec to include positive and negative case Also fixed some style nits. https://bugzilla.redhat.com/show_bug.cgi?id=1347248 .../miq_capacity/_bottlenecks_options.html.haml_spec.rb | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/fb78588d25f91c6068749a9ecd8a91ee851c0415 commit fb78588d25f91c6068749a9ecd8a91ee851c0415 Author: Brian McLaughlin <bmclaugh> AuthorDate: Mon Jun 27 16:42:40 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Mon Jun 27 16:42:40 2016 -0400 Remove commented code https://bugzilla.redhat.com/show_bug.cgi?id=1347248 spec/views/miq_capacity/_bottlenecks_options.html.haml_spec.rb | 1 - 1 file changed, 1 deletion(-)
Verified in 5.7.0.3