Red Hat Bugzilla – Bug 134744
RHEL4: modules: put srcversion checksum in each modinfo section
Last modified: 2015-01-04 17:10:19 EST
Date: Tue, 5 Oct 2004 17:02:11 -0500
From: Matt Domsch <Matt_Domsch@dell.com>
To: firstname.lastname@example.org, Rusty Russell <email@example.com>
Subject: [PATCH 2.6.9-rc3] modules: put srcversion checksum in each
Separate the module source and header checksum into a separate
With CONFIG_MODULE_SRCVERSION_ALL=y, put srcversion into every module,
not just those with MODULE_VERSION("something").
Patch by Rusty Russell, trivial merging and testing by Matt Domsch
Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
include/linux/module.h | 6 +--
init/Kconfig | 12 +++++++
scripts/Makefile.modpost | 1
scripts/mod/modpost.c | 65 +++++++++++++++++++++++++++++++++++--
scripts/mod/modpost.h | 10 +++--
scripts/mod/sumversion.c | 80 ++++++++-----------------------------
6 files changed, 96 insertions, 78 deletions
DKMS could use this information to tell if a driver source has
changed or not,
regardless of if the driver author put a MODULE_VERSION() tag in it.
w/o patch, modinfo doesn't show a 'srcversion' field
w patch and CONFIG_MODULE_SRCVERSION_ALL=y, modinfo shows
a 'srcversion' field
for all modules.
Created attachment 104813 [details]
Patch sent to akpm today.
This patch was just committed to Linus's 2.6 bitkeeper repo.
Our intention is include the MODULE_VERSION in all of the main network
and storage drivers in RHEL4 RC. In conjunction, we are implementing
the RPM based dependencies which Jeremy described to you. We can't
really make use of the checksum from a versioning standpoint. Unless
we went through the unmaintainable trauma of having a database of
every shipped driver & respective version.
For this reason, the incremental value of adding in this change isn't
compelling to put in this late in the game. In a later update, when
we rebase, it would then be picked up.
OK, but you probably won't rebase for an update, so it becomes a "you
get it for free in RHEL5" thing.