Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1347765

Summary: unchecked string generation allows for buffer overflow and coredump
Product: Red Hat Enterprise Linux 7 Reporter: Martin Poole <mpoole>
Component: libcgroupAssignee: Nikola Forró <nforro>
Status: CLOSED ERRATA QA Contact: Chao Ye <cye>
Severity: high Docs Contact:
Priority: high    
Version: 7.2CC: cye, hartsjc, ovasik, vanhoof, varekova
Target Milestone: rcKeywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libcgroup-0.41-11.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-04 04:41:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1203710    
Attachments:
Description Flags
api.c: fix potential buffer overflow none

Description Martin Poole 2016-06-17 14:57:05 UTC
Description of problem:

cg_get_procname_from_proc_cmdline in api.c makes the unwarranted assumption that a given /proc/<PID>/cmdline will fit in FILENAME_MAX characters (including terminating NUL)

This assumption has been seen to cause failures when command lines are are dynamically created in grid environments.


Version-Release number of selected component (if applicable):

libcgroup-0.41-8.el7


Additional info:

Comment 2 James Hartsock 2016-06-17 15:42:16 UTC
As was stated by Martin, this is causing grid computing jobs to fail for this TAM customer.  But the customer also has concern about fact there is a buffer overflow in a service running as root.  Thus customer is very anxious to get a fix here.  They are generally very good about about testing pre-GA RPMs if we need too.

Thank you.

Comment 3 Nikola Forró 2016-06-19 16:10:11 UTC
Created attachment 1169532 [details]
api.c: fix potential buffer overflow

Comment 5 James Hartsock 2016-06-19 21:49:23 UTC
Provided to customer for testing, will let you know their feedback.

Thank you!

Comment 10 errata-xmlrpc 2016-11-04 04:41:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2364.html