Bug 1347957 - [RFE] Support custom sub-stages
Summary: [RFE] Support custom sub-stages
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: otopi
Classification: oVirt
Component: Core
Version: master
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ---
Assignee: Yedidyah Bar David
QA Contact: Pavel Stehlik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-19 07:01 UTC by Yedidyah Bar David
Modified: 2017-07-20 07:40 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-07-20 07:40:37 UTC
oVirt Team: Integration
Embargoed:
dfediuck: ovirt-future?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1346618 0 unspecified CLOSED [Docs][Beta] Update the installation and configuration steps for standard RHV-M 2021-02-22 00:41:40 UTC
oVirt gerrit 64297 0 master ABANDONED core: Add substages metadata 2017-07-16 08:53:29 UTC
oVirt gerrit 64298 0 master ABANDONED core: Support substages 2017-07-16 08:53:35 UTC
oVirt gerrit 64299 0 master ABANDONED debug plugins: Add test_substages 2017-07-16 08:53:41 UTC

Internal Links: 1346618

Description Yedidyah Bar David 2016-06-19 07:01:07 UTC
Description of problem:

It will be useful for plugins to be able to add sub-stages and declare that an event should run at some specific sub-stage.

Sub-stages should then run without overlaps.

Examples:

1. In engine-setup, during customization stage, we have "Product options", then "Packages", "Network configuration" etc. Currently these are hard-coded as events in several titles.py files. If two optional plugin packages want to add their own, they can't make sure their events will not be mixed. Also a solution to current bug might make it possible to not show the titles themselves during run if there are no questions to ask (or other output).

2. Each of engine and dwh have (among others) these two events: Provisioning (asking "Where is the XXX database located" and if 'local', asking "Would you like Setup to automatically configure postgresql"), then manual/remote Credentiuals ("database secured connection", "database name" etc).
Currently they are mixed: First we prompt "Provisioning" for both, then "Credentials" for both. It's not easy to make them not mixed. It should be possible for engine plugin to define a sub-stage "Engine Database Customization" with both events in it, for DWH to define similar, and have them run one after the other. It's probably useful also to be able to define order for these sub-stages (e.g. for dwh to define it should run after engine).

I didn't check deeply the exact current behavior, opening this bug based on reports.

A workaround might be to rename the events, as by default otopi sorts events by name, after fulfilling before/after/priority requirements.

Comment 1 Yedidyah Bar David 2017-03-13 08:26:50 UTC
I started working on this some time ago [1] and it turned out to be more complex than expected, if I want to solve the most general case. Perhaps we should define a more strict subset that is still useful, if at all. We should also consider bug 1367457 and especially alt1 there.

[1] https://gerrit.ovirt.org/#/q/project:otopi+status:open+message:substages

Comment 2 Yedidyah Bar David 2017-07-20 07:40:37 UTC
Closing for now. Might reopen in the future with more concrete needs and probably less general implementation. Above patches were abandoned, remove "status:open" if you want to look at them.


Note You need to log in before you can comment on or make changes to this bug.