Spec URL: http://msimacek.fedorapeople.org/review/pasystray/pasystray.spec SRPM URL: http://msimacek.fedorapeople.org/review/pasystray/pasystray-0.5.2-1.fc23.src.rpm Description: A replacement for the deprecated padevchooser. pasystray allows setting the default PulseAudio source/sink and moving streams on the fly between sources/sinks without restarting the client applications. Fedora Account System Username: msimacek
Koji scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14561990
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/gil/1347987-pasystray/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in pasystray [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pasystray-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pasystray-0.5.2-1.fc25.i686.rpm pasystray-debuginfo-0.5.2-1.fc25.i686.rpm pasystray-0.5.2-1.fc25.src.rpm pasystray.i686: W: spelling-error %description -l en_US padevchooser -> preschooler pasystray.i686: W: non-conffile-in-etc /etc/xdg/autostart/pasystray.desktop pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_action.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/options.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/menu_info.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/x11-property.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_action.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/avahi.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/menu_info.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/ui.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/avahi.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/notify.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/x11-property.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pasystray.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/notify.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/options.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_info.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/ui.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_info.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray_impl.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray_impl.h pasystray.src: W: spelling-error %description -l en_US padevchooser -> preschooler 3 packages and 0 specfiles checked; 23 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: pasystray-debuginfo-0.5.2-1.fc25.i686.rpm pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/options.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pasystray.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/ui.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray_impl.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/ui.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/x11-property.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/x11-property.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_info.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/menu_info.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_action.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/menu_info.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/notify.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray_impl.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/avahi.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_action.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/notify.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/systray.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/avahi.h pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/options.c pasystray-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pasystray-0.5.2/src/pulseaudio_info.h 1 packages and 0 specfiles checked; 23 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- INFO: mock.py version 1.2.18 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.18 INFO: Mock Version: 1.2.18 Finish: chroot init INFO: installing package(s): rpmlint ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 25 --disableplugin=local --setopt=deltarpm=false install rpmlint --setopt=tsflags=nocontexts Requires -------- pasystray (rpmlib, GLIBC filtered): /bin/sh libX11.so.6 libatk-1.0.so.0 libc.so.6 libcairo-gobject.so.2 libcairo.so.2 libgdk-3.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-3.so.0 libnotify.so.4 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 libpulse-mainloop-glib.so.0 libpulse-mainloop-glib.so.0(PULSE_0) libpulse.so.0 libpulse.so.0(PULSE_0) rtld(GNU_HASH) pasystray-debuginfo (rpmlib, GLIBC filtered): Provides -------- pasystray: application() application(pasystray.desktop) pasystray pasystray(x86-32) pasystray-debuginfo: pasystray-debuginfo pasystray-debuginfo(x86-32) Source checksums ---------------- https://github.com/christophgysin/pasystray/archive/0.5.2.tar.gz : CHECKSUM(SHA256) this package : 7fca039a408c9187938402a013150f22a485196601f2f37d790b304dce11a4e6 CHECKSUM(SHA256) upstream package : 7fca039a408c9187938402a013150f22a485196601f2f37d790b304dce11a4e6 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1347987 --plugins C/C++ -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Please, report to upstream "E: incorrect-fsf-address" Approved
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pasystray
pasystray-0.5.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9b5f0900bc
pasystray-0.5.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d06433e715
pasystray-0.5.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9b5f0900bc
pasystray-0.5.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d06433e715
pasystray-0.6.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-76c8378666
pasystray-0.5.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
pasystray-0.5.2-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
pasystray-0.6.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-76c8378666
pasystray-0.6.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.