Bug 1348056 - cli core dumped while providing/not wrong values during arbiter replica volume
Summary: cli core dumped while providing/not wrong values during arbiter replica volume
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: arbiter
Version: 3.7.12
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ravishankar N
QA Contact:
URL:
Whiteboard:
Depends On: 1346821
Blocks: 1348055
TreeView+ depends on / blocked
 
Reported: 2016-06-20 04:11 UTC by Ravishankar N
Modified: 2016-07-20 13:55 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.7.13
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1346821
Environment:
Last Closed: 2016-07-20 13:55:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ravishankar N 2016-06-20 04:11:22 UTC
+++ This bug was initially created as a clone of Bug #1346821 +++

Description of problem:

[root@dhcp43-153 ~]# gluster v create rep arbiter 3 10.70.43.153:/rhs/brick{1..3}/brick force
gluster: cli-cmd-parser.c:632: cli_cmd_volume_create_parse: Assertion `!"opword mismatch"' failed.
Aborted (core dumped)
[root@dhcp43-153 ~]# 


Version-Release number of selected component (if applicable):
glusterfs --version
glusterfs 3.9dev built on Jun  8 2016 14:50:20
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2013 Red Hat, Inc. <http://www.redhat.com/>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
It is licensed to you under your choice of the GNU Lesser
General Public License, version 3 or any later version (LGPLv3
or later), or the GNU General Public License, version 2 (GPLv2),
in all cases as published by the Free Software Foundation.


How reproducible:
100%

Steps to Reproduce: 
Don't give "replica 3" 
1. gluster v create rep arbiter 3 10.70.43.153:/rhs
2. 
3.

Actual results:
core dumped

Expected results:
It should display a message with correct usage help.

Additional info:

--- Additional comment from Ravishankar N on 2016-06-15 10:15:36 EDT ---

Are you working on the fix Ashish?

--- Additional comment from Ashish Pandey on 2016-06-15 14:37:25 EDT ---


No, I just raised this bug and continued to reproduce other bug on which I was working and found this.

--- Additional comment from Ravishankar N on 2016-06-15 21:01:35 EDT ---

Okay.

--- Additional comment from Vijay Bellur on 2016-06-16 00:55:49 EDT ---

REVIEW: http://review.gluster.org/14738 (cli: fix crash in arbiter keyword parsing) posted (#1) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-06-17 03:29:16 EDT ---

REVIEW: http://review.gluster.org/14738 (cli: fix crash in arbiter keyword parsing) posted (#2) for review on master by Ravishankar N (ravishankar)

--- Additional comment from Vijay Bellur on 2016-06-17 06:56:43 EDT ---

COMMIT: http://review.gluster.org/14738 committed in master by Atin Mukherjee (amukherj) 
------
commit b5c492dfea2d2e2075aa88d7153fba57b06e739d
Author: Ravishankar N <ravishankar>
Date:   Thu Jun 16 10:21:53 2016 +0530

    cli: fix crash in arbiter keyword parsing
    
    A negative case like `gluster volume create volname arbiter 3 /bricks{1..3}`
    must not crash. 'arbiter' keyword is valid only for (3 way) replica volumes.
    
    The .t that is added will crash and create a core *without* the fix when
    run but will still pass all TESTs. Since the regression framework fails
    the .t if it creates a core,  we can consider it a valid test 'that
    fails without the fix'.
    
    Change-Id: Ie2d7ced66025ea3617d30f6f823b22401e6d2fde
    BUG: 1346821
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/14738
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 1 Vijay Bellur 2016-06-20 04:12:19 UTC
REVIEW: http://review.gluster.org/14765 (cli: fix crash in arbiter keyword parsing) posted (#1) for review on release-3.7 by Ravishankar N (ravishankar)

Comment 2 Vijay Bellur 2016-06-28 06:37:11 UTC
COMMIT: http://review.gluster.org/14765 committed in release-3.7 by Atin Mukherjee (amukherj) 
------
commit 984ebffd03aaf6e1da9981b804d5a368e56150ee
Author: Ravishankar N <ravishankar>
Date:   Thu Jun 16 10:21:53 2016 +0530

    cli: fix crash in arbiter keyword parsing
    
    Backport of http://review.gluster.org/#/c/14738/
    
    A negative case like `gluster volume create volname arbiter 3 /bricks{1..3}`
    must not crash. 'arbiter' keyword is valid only for (3 way) replica volumes.
    
    The .t that is added will crash and create a core *without* the fix when
    run but will still pass all TESTs. Since the regression framework fails
    the .t if it creates a core,  we can consider it a valid test 'that
    fails without the fix'.
    
    Change-Id: Ie2d7ced66025ea3617d30f6f823b22401e6d2fde
    BUG: 1348056
    Signed-off-by: Ravishankar N <ravishankar>
    (cherry picked from commit b5c492dfea2d2e2075aa88d7153fba57b06e739d)
    Reviewed-on: http://review.gluster.org/14765
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Kaushal 2016-07-20 13:55:32 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.13, please open a new bug report.

glusterfs-3.7.13 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-July/027604.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.