Hide Forgot
Created attachment 1169647 [details] screenshot Description of problem: Should give a reminder about update firefox version on rhevm4.0 if firefox version is too low to load hardware info in dashboard Version-Release number of selected component (if applicable): RHEVM:4.0.0.4-0.1.el7ev firefox-38.1.0-1.el6_6.x86_64 firefox-38.3.0-2.el7_1.x86_64 How reproducible: 100% Steps to Reproduce: 1 Login rhevm4.0 by FQDN: https://ibm-x3250m5-03.rhts.eng.pek2.redhat.com/ovirt-engine/ 2.Click dashboard option, it always shows loading even if waiting for a long time,pls refer to screenshot 3.Update firefox to below version, then rhevm4.0 could load the hardware info in dashboard normally firefox-45.1.1-1.el7_2.x86_64 firefox-45.0.1-1.el6.x86_64 Actual results: As above description Expected results: Should give a reminder about update firefox version on rhevm4.0 if firefox version is too low to load hardware info in dashboard Additional info:
Greg - we recently changed the "error" message we give when loading. Any ideas here?
We removed the message because we should support everything in all modern browsers. In this case, FF 38 is relatively new, and is an ESR, so I would consider this a dashboard bug.
Okay. Changed accordingly. Let's check if the latest fixes help with that at all and continue from there.
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
The root cause is that we're using a relatively new feature, Array.includes(), in our own code. According to mozilla.org [1], this feature was introduced only in Firefox 43. There is a polyfill npm module available called array-includes. I gave it a quick try and it didn't fix the issue. I might mess with it a bit more, or I might just replace it with Array.indexOf() :) [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
We aren't fixing this. It was also raised in other bugs. Closing. Thanks Greg for digging into that.