Bug 1348451

[root@orchid-vds2 ~]# less /var/lib/vdsm/persistence/netconf 
/var/lib/vdsm/persistence/netconf: No such file or directory

What does it mean "badly persisted"? comment 1 claims that nothing was persisted.

What's `virsh -r net-list`?

Can you attach your ifcfg-*?

There is no ifcfg-ovirtmgmt.
Any how i already took the host. once it will happen again, and i believe it will i will let you know. like i said it seems that it was not persisted, although vdsm trying to restore it.

This is reproduced again. now i'm almost sure it is related to bug 1348103. once the host auto recovered from the add host failure, it didn't persisted the ovirtmgmt, there was no set safe on the bridge on the auto recover.

- After host auto recover and before reboot :

 [root@orchid-vds2 ~]# cat /var/lib/vdsm/persistence/netconf
cat: /var/lib/vdsm/persistence/netconf: No such file or directory

[root@orchid-vds2 ~]# cat /etc/sysconfig/network-scripts/ifcfg-ovirtmgmt 
# Generated by VDSM version 4.18.3-0.el7ev
DEVICE=ovirtmgmt
TYPE=Bridge
DELAY=0
STP=off
ONBOOT=yes
BOOTPROTO=dhcp
MTU=1500
DEFROUTE=yes
NM_CONTROLLED=no
IPV6INIT=no

  
[root@orchid-vds2 ~]# cat /var/run/vdsm/netconf/nets/ovirtmgmt 
{
    "ipv6autoconf": false, 
    "bridged": true, 
    "nic": "enp4s0", 
    "mtu": 1500, 
    "switch": "legacy", 
    "dhcpv6": false, 
    "stp": false, 
    "hostQos": {
        "out": {
            "ls": {
                "m2": 50
            }
        }
    }, 
    "defaultRoute": true, 
    "bootproto": "dhcp"

[root@orchid-vds2 ~]# virsh -r net-list
 Name                 State      Autostart     Persistent
----------------------------------------------------------
 ;vdsmdummy;          active     no            no
 default              active     no            yes
 vdsm-ovirtmgmt       active     yes           yes

- After reboot ->

root@orchid-vds2 ~]# virsh -r net-list
 Name                 State      Autostart     Persistent
----------------------------------------------------------
 ;vdsmdummy;          active     no            no
 vdsm-ovirtmgmt       active     yes           yes


[root@orchid-vds2 ~]# cat /var/run/vdsm/netconf/nets/ovirtmgmt 
cat: /var/run/vdsm/netconf/nets/ovirtmgmt: No such file or directory

[root@orchid-vds2 ~]# cat /etc/sysconfig/network-scripts/ifcfg-ovirtmgmt 
cat: /etc/sysconfig/network-scripts/ifcfg-ovirtmgmt: No such file or directory

[root@orchid-vds2 ~]# cat /var/lib/vdsm/persistence/netconf
cat: /var/lib/vdsm/persistence/netconf: No such file or directory

I managed to reproduce this bug without 1348103. After a successful add host(ovirtmgmt was persisted), i attached several network to the host via setup networks, non of them was persisted and all of them failed to restore by vdsm. 
This is happening from time to time.
- The summery of the bug should be changed, cause it happening to all networks, not only ovirtmgmt.

Dan, could it be related to the revert on this BZ  https://bugzilla.redhat.com/show_bug.cgi?id=1340234 ? 
I'm not sure i even can verify it ^^

(In reply to Michael Burman from comment #5)
> I managed to reproduce this bug without 1348103. After a successful add
> host(ovirtmgmt was persisted), i attached several network to the host via
> setup networks, non of them was persisted and all of them failed to restore
> by vdsm. 
> This is happening from time to time.
> - The summery of the bug should be changed, cause it happening to all
> networks, not only ovirtmgmt.
> 
> Dan, could it be related to the revert on this BZ 
> https://bugzilla.redhat.com/show_bug.cgi?id=1340234 ? 
> I'm not sure i even can verify it ^^

Clearly, if setSafeNetConfig was never sent from Engine, nothing would be persistent. The bug here is different - we got to an inconsistent state..
What you describe in comment 5 is unrelated to this bug as well as to bug 1340234.

Ok, i will do my best to reproduce it and report a new bug.

From the logs, VDSM did not received setSafeNetworkConfig from Engine, therefore, the config has not been persisted. 
On reboot it came back to the original non VDSM config.

This issue has not been recreated for the last month.
The investigation only revealed that the cause of the problem is due to the missing setSafeNetworkConfig instruction from Engine.

Therefore, we are closing this bug for now, if the problem is seen again, please reopen the bug and provide logs from Engine and VDSM (vdsm, supervdsm).