Bug 1348703
| Summary: | fsck.gfs2: "undo" functions can stop too early on duplicates | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Robert Peterson <rpeterso> | ||||||
| Component: | gfs2-utils | Assignee: | Robert Peterson <rpeterso> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 7.3 | CC: | cluster-maint, djansa, gfs2-maint, jpayne | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | gfs2-utils-3.1.9-2.el7 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-11-04 06:31:15 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Robert Peterson
2016-06-21 20:11:20 UTC
Created attachment 1170387 [details]
Proposed RHEL7 patch
Created attachment 1176465 [details] Additional non-metadata blocks required Notes on recreation for QE: Like so many fsck.gfs2 problems I've found, this one requires some special non-saved metadata blocks to recreate it (see the attached file). Without this additional bit, it won't recreate. So to reliably recreate the problem, do this: gfs2_edit restoremeta /home/bob/metadata/gfs/dirty/Case_00434286_metadata_vg3 <device> dd if=/home/bob/bz1348703.blk.0x19ccfd10.to.4f of=<device> bs=4096 seek=432864528 fsck.gfs2 -y <device> &> /tmp/fsck.out fsck.gfs2 <device> Actual output: [root@gfs-i24c-01 /home/bob]# gfs2_edit restoremeta /home/bob/metadata/gfs/dirty/Case_00434286_metadata_vg3 /dev/monsta/scratch1 No valid file header found. Falling back to old format... Block size is 4096B This is gfs1 metadata. There are 536870912 free blocks on the destination device. Highest saved block is 438957066 (0x1a29f40a) 438957067 blocks processed, 1290843 saved (100%) File /home/bob/metadata/gfs/dirty/Case_00434286_metadata_vg3 restore successful. You have new mail in /var/spool/mail/root [root@gfs-i24c-01 /home/bob]# dd if=/home/bob/bz1348703.blk.0x19ccfd10.to.4f of=/dev/monsta/scratch1 bs=4096 seek=432864528 64+0 records in 64+0 records out 262144 bytes (262 kB) copied, 0.00216448 s, 121 MB/s [root@gfs-i24c-01 /home/bob]# sync [root@gfs-i24c-01 /home/bob]# fsck.gfs2 -y /dev/monsta/scratch1 &> /tmp/fsck.1348703.out [root@gfs-i24c-01 /home/bob]# echo $? 1 [root@gfs-i24c-01 /home/bob]# fsck.gfs2 /dev/monsta/scratch1 Initializing fsck Validating resource group index. Level 1 resource group check: Checking if all rgrp and rindex values are good. (level 1 passed) Clearing GFS journals (this may take a while) .. Journals cleared. Journal recovery complete. Starting pass1 Large file at 196 (0xc4) - 100 percent complete. Reconciling bitmaps. Block 432864494 (0x19ccfcee) bitmap says 1 (data) but FSCK saw 0 (free) Fix bitmap for block 432864494 (0x19ccfcee) ? (y/n) The upstream patch is now pushed here: https://git.fedorahosted.org/cgit/gfs2-utils.git/commit/?id=6b40deabbbbd59a1cbddbe633984214b6752d25a The RHEL7 patch is now pushed here: https://git.fedorahosted.org/cgit/gfs2-utils.git/commit/?h=RHEL7&id=0a0d4af99c9be8abc863e272d6e7f46bb6ad4b41 It was tested on gfs-i24c-01.mpc.lab.eng.bos.redhat.com. Changing status to POST until it gets built into a new gfs2-utils for RHEL7.3. Verified in gfs2-utils-3.1.9-3.el7: [root@south-16 ~]# rpm -q gfs2-utils gfs2-utils-3.1.9-3.el7.x86_64 [root@south-16 ~]# gfs2_edit restoremeta Case_00434286_metadata_vg3 /dev/sdb1 No valid file header found. Falling back to old format... Block size is 4096B This is gfs1 metadata. There are 469649399 free blocks on the destination device. Highest saved block is 438957066 (0x1a29f40a) 438957067 blocks processed, 1290843 saved (100%) File Case_00434286_metadata_vg3 restore successful. [root@south-16 ~]# fsck.gfs2 -y /dev/sdb1 &> /tmp/fsck.out [root@south-16 ~]# fsck.gfs2 /dev/sdb1 Initializing fsck Validating resource group index. Level 1 resource group check: Checking if all rgrp and rindex values are good. (level 1 passed) Clearing GFS journals (this may take a while) .. Journals cleared. Journal recovery complete. Starting pass1 Large file at 196 (0xc4) - 100 percent complete. Reconciling bitmaps. reconcile_bitmaps completed in 8.286s pass1 completed in 2m4.530s Starting pass1b pass1b completed in 0.000s Starting pass2 pass2 completed in 55.084s Starting pass3 pass3 completed in 0.000s Starting pass4 pass4 completed in 2.115s Starting check_statfs check_statfs completed in 0.000s gfs2_fsck complete Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2438.html |