Bug 1348721 - VM console button superfluously warns it may fail
Summary: VM console button superfluously warns it may fail
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.8.0
Assignee: Martin Povolny
QA Contact: Kedar Kulkarni
URL:
Whiteboard: html5
Depends On:
Blocks: 1412284
TreeView+ depends on / blocked
 
Reported: 2016-06-21 21:17 UTC by Jeff Warnica
Modified: 2017-06-12 17:39 UTC (History)
6 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1412284 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:39:35 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jeff Warnica 2016-06-21 21:17:06 UTC
Description of problem:

Seems to exist in 4.0 and late 4.1 betas

From vm_infra/explorer, when the HTML5 console button is clicked, it blocks and locks the UI (and entire browser) with a modal dialog warning the user it may fail: "Opening a web-based VM VNC or SPICE console requires that the Provider is pre-configured to allow VNC connections.  Are you sure?"


How reproducible:

every time

Steps to Reproduce:
1. Click VM console button

Actual results:

Warning presented


Expected results:

No warning presented

Comment 4 CFME Bot 2016-11-16 12:41:14 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/0c52cd45866c777e487511ad3520985228a769d4

commit 0c52cd45866c777e487511ad3520985228a769d4
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Nov 16 11:41:18 2016 +0100
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Nov 16 11:41:18 2016 +0100

    Remove confirmation when opening the HTML5 vnc/spice console.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1348721

 .../toolbar/cloud/instance_operations_button_group_mixin.rb            | 3 +--
 app/helpers/application_helper/toolbar/x_vm_center.rb                  | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

Comment 5 Satoe Imaishi 2017-01-05 22:27:55 UTC
Martin, can this move to POST?

Comment 7 CFME Bot 2017-01-13 14:20:57 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/2b083ff0e97a65235cbcd3669b7fe9615b4e986e

commit 2b083ff0e97a65235cbcd3669b7fe9615b4e986e
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Nov 16 11:41:18 2016 +0100
Commit:     Martin Povolny <mpovolny>
CommitDate: Thu Jan 12 09:15:26 2017 +0100

    Remove confirmation when opening the HTML5 vnc/spice console.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1348721
    
    1/2 of this was done as part of 9b38984d for Euwe.

 .../toolbar/cloud/instance_operations_button_group_mixin.rb            | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comment 8 Kedar Kulkarni 2017-04-25 17:03:27 UTC
No warning is being presented as of now. Marking Bug as resolved.


Note You need to log in before you can comment on or make changes to this bug.