Bug 1348908 - Wrong html markup in SNMP section of an Alert
Summary: Wrong html markup in SNMP section of an Alert
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: All
OS: All
low
low
Target Milestone: GA
: 5.7.0
Assignee: Eric Hayes
QA Contact: Dmitry Misharov
URL:
Whiteboard: ui:alert
: 1357817 (view as bug list)
Depends On:
Blocks: 1353277 1357817
TreeView+ depends on / blocked
 
Reported: 2016-06-22 09:46 UTC by Dmitry Misharov
Modified: 2017-01-12 05:12 UTC (History)
6 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1353277 1357817 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:30:52 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Screenshot of the bug (164.73 KB, image/png)
2016-06-22 09:46 UTC, Dmitry Misharov
no flags Details

Description Dmitry Misharov 2016-06-22 09:46:04 UTC
Created attachment 1170649 [details]
Screenshot of the bug

Description of problem:
<label class="control-label col-md-2"> used instead of <div class="form-horizontal">

Version-Release number of selected component (if applicable):
5.6.0.11-rc2.2.20160614152915_f315c68 

How reproducible:
Always

Steps to Reproduce:
1. Navigate to Control->Explorer.
2. Expand Alert accordion.
3. Create an Alert with SNMP.

Actual results:
The resulted alert has wrong html markup in SNMP section.

Expected results:
SNMP section should look correctly.

Comment 1 Harpreet Kataria 2016-06-22 13:30:24 UTC
Eric,

Looks like need to fix HAML tags in https://github.com/ManageIQ/manageiq/blob/master/app/views/miq_policy/_alert_details.html.haml#L191 block.

Let me know if you have questions.

Thanks,
~Harpreet

Comment 4 CFME Bot 2016-06-23 20:06:40 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/de453cf572a16bc835cbaf4efe84ec95c24cfe41

commit de453cf572a16bc835cbaf4efe84ec95c24cfe41
Author:     Eric Hayes <eric>
AuthorDate: Wed Jun 22 10:35:41 2016 -0700
Commit:     Eric Hayes <eric>
CommitDate: Thu Jun 23 07:57:01 2016 -0700

    Fix markup to correctly display SNMP traps
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1348908

 app/views/miq_policy/_alert_details.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 7 Dmitry Misharov 2016-09-09 08:36:57 UTC
Fixed and verified in 5.7.0.0.20160906172503_12f65cb. The markup in SNMP section of an alert looks normally.

Comment 8 John Prause 2016-09-09 13:10:56 UTC
*** Bug 1357817 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.