Bug 1349119 - Review Request: jwm - Joe's Window Manager
Summary: Review Request: jwm - Joe's Window Manager
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1349118 (view as bug list)
Depends On:
Blocks: 1233464
TreeView+ depends on / blocked
 
Reported: 2016-06-22 18:13 UTC by Igor Gnatenko
Modified: 2016-07-07 09:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-07 09:46:52 UTC
Type: ---
Embargoed:
gwync: fedora-review+


Attachments (Terms of Use)

Description Igor Gnatenko 2016-06-22 18:13:45 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/jwm.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/jwm-2.3.5-1.fc25.src.rpm
Description:
JWM is a window manager for the X11 Window System. It's written in C and uses
only Xlib at a minimum. The following libraries can also be used if available:

* cairo and librsvg2 for SVG icons and backgrounds.
* fribidi for bi-directional text support.
* libjpeg for JPEG icons and backgrounds.
* libpng for PNG icons and backgrounds.
* libXext for the shape extension.
* libXrender for the render extension.
* libXmu for rounded corners.
* libXft for anti-aliased and true type fonts.
* libXinerama for multiple head support.
* libXpm for XPM icons and backgrounds.

JWM supports MWM and Extended Window Manager Hints (EWMH).

Note that Fedora package is built with all supported features enabled.
Fedora Account System Username: ignatenkobrain

Comment 1 Igor Gnatenko 2016-06-22 18:14:29 UTC
Review Request is required for un-retiring package for master branch.

Comment 2 Gwyn Ciesla 2016-06-22 18:19:28 UTC
*** Bug 1349118 has been marked as a duplicate of this bug. ***

Comment 3 Gwyn Ciesla 2016-06-22 18:38:43 UTC
- rpmlint checks return:
wm.x86_64: W: spelling-error %description -l en_US cairo -> Cairo, cairn
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US fribidi -> frigidity
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libjpeg -> libel
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libpng -> sibling
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXext -> liberty
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXrender -> slenderer
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXmu -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXft -> lift
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXinerama -> Cinerama
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXpm -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/jwm-2.3.5/src/debug.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

2 packages and 0 specfiles checked; 1 errors, 10 warnings.

Ignorable.

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


Meets all requirements.  APPROVED.

Comment 4 Igor Gnatenko 2016-07-07 09:46:52 UTC
In stable repos of F24+.


Note You need to log in before you can comment on or make changes to this bug.