Description of problem: If Session config or Template config not found, Geo-rep will silently ignore and causes other problems like wrong mount params, wrong paths etc. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Create Geo-rep session 2. Move Template config file and session config file from /var/lib/glusterd/geo-replication 3. Start Geo-replication Actual results: Geo-rep will not fail, but substitute wrong config values when used. (We can observe wrong Mount parameters, ps -ax | grep gsyncd | grep glusterfs) Expected results: Geo-rep should go to Faulty if unable to read config file.
REVIEW: http://review.gluster.org/14777 (geo-rep: Handle Config parser errors) posted (#1) for review on master by Aravinda VK (avishwan)
REVIEW: http://review.gluster.org/14777 (geo-rep: Handle Config parser errors) posted (#2) for review on master by Aravinda VK (avishwan)
REVIEW: http://review.gluster.org/14777 (geo-rep: Handle Config parser errors) posted (#3) for review on master by Aravinda VK (avishwan)
COMMIT: http://review.gluster.org/14777 committed in master by Jeff Darcy (jdarcy) ------ commit d94bf608b16b82f2c8f8588a96459cb746773b32 Author: Aravinda VK <avishwan> Date: Thu Jun 23 11:53:36 2016 +0530 geo-rep: Handle Config parser errors Python ConfigParser lib has two methods, readfp and read, it should be used as follows. readfp(open("defaults.conf")) read("custom.conf") ConfigParser.read(path) ignores any file errors, which is intentional since errors are handled while loading default config. Geo-rep uses only one config file(Session config in Master side and Template config on Slave side) so we should use readfp to avoid skipping OS errors. config.read is retained in case of `--config-set-rx` where glusterd creates new template config file. BUG: 1349273 Change-Id: I15a14d3743facd7b8c7af0edc70fdefaa43efd04 Signed-off-by: Aravinda VK <avishwan> Reviewed-on: http://review.gluster.org/14777 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report. glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html [2] https://www.gluster.org/pipermail/gluster-users/