Red Hat Bugzilla – Bug 1349465
[bash-completion] put it under $(pkg-config --variable=completionsdir bash-completion) to allow for dynamic loading
Last modified: 2016-11-03 16:59:09 EDT
First mentioned in [bug 1305049 comment 11] that also sparkled https://github.com/scop/bash-completion/issues/51 As Ville pointed out, right directory has to be chosen for the completion file so as to allow for dynamic treatment. Unfortunately, pcs hardcodes the old/backward-compatibility one: rpm -ql pcs | grep bash > /etc/bash_completion.d/pcs (https://pkgs.fedoraproject.org/cgit/rpms/pcs.git/tree/pcs.spec?id=de104aad02076d4814cc5fe0b3f9791ae0f33e3d#n109) Please use the path per Summary so as to enable any update being instantly reflected without a need to reload/restart/exec new shell environment.
Created attachment 1174875 [details] proposed fix
Before fix: [vm-rhel72-1 ~] $ rpm -q pcs pcs-0.9.151-1.el7.x86_64 [vm-rhel72-1 ~] $ rpm -ql pcs | grep bash /etc/bash_completion.d/pcs After fix: [vm-rhel72-1 ~] $ rpm -q pcs pcs-0.9.152-3.el7.x86_64 [vm-rhel72-1 ~] $ rpm -ql pcs | grep bash /usr/share/bash-completion/completions/pcs
Created attachment 1184680 [details] proposed fix Test: [vm-rhel72-1 ~pcs] $ make install BASH_COMPLETION_DIR=/usr/share/bash-completion ... install -D -m644 pcs/bash_completion.sh /usr/share/bash-completion/pcs ... [vm-rhel72-1 ~pcs] $ ls -l /usr/share/bash-completion |grep pcs -rw-r--r--. 1 root root 1029 27. čec 16.40 pcs
Before Fix: [vm-rhel72-1 ~] $ rpm -q pcs pcs-0.9.152-4.el7.x86_64 [vm-rhel72-1 ~] $ ll /usr/share/bash-completion/completions/ |grep pcs -rwxr-xr-x. 1 root root 1029 15. čec 15.22 pcs After Fix: [vm-rhel72-1 ~] $ rpm -q pcs pcs-0.9.152-5.el7.x86_64 [vm-rhel72-1 ~] $ ll /usr/share/bash-completion/completions/ |grep pcs -rw-r--r--. 1 root root 1029 28. čec 2016 pcs
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2596.html