Spec URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf.spec SRPM URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf-0.6.0-1.fc24.src.rpm Description: Pifpaf is a suite of fixtures to manage daemons
Looks good, few things. * You can drop the two fallback macros on top, they're not needed anymore. * Package fails to install as pyxattr is not named correctly. I'll look to fix it python-xattr => pyxattr python3-xattr => python3-pyxattr * Python3 binaries symlinks are broken as there's no python3-pifpaf binary. I suggest that you use python-saharaclient as a template http://pkgs.fedoraproject.org/cgit/rpms/python-saharaclient.git/tree/python-saharaclient.spec#n93 Needinfo me when it's done.
thanks addressed your comments: please check: Spec URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf.spec SRPM URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf-0.6.0-2.fc24.src.rpm
rebased to 0.12.0 Spec URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf.spec SRPM URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf-0.12.0-1.fc24.src.rpm
One small glitch in Source0 to fix before import: Source0: https://pypi.io/packages/source/p/%{pypi_name}/%{pypi_name}-%{version}.tar.gz This package is hereby approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 8 files have unknown license. Detailed output of licensecheck in /home/haikel/1349578-python-pifpaf/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://pypi.io/packages/source/p/pifpaf-0.12.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-pifpaf , python3-pifpaf [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-pifpaf-0.12.0-1.fc26.noarch.rpm python3-pifpaf-0.12.0-1.fc26.noarch.rpm python-pifpaf-0.12.0-1.fc26.src.rpm python2-pifpaf.noarch: W: no-manual-page-for-binary pifpaf python2-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-2 python2-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-2.7 python3-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-3.5 python3-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-3 python-pifpaf.src: W: invalid-url Source0: https://pypi.io/packages/source/p/pifpaf-0.12.0.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- python2-pifpaf.noarch: W: no-manual-page-for-binary pifpaf python2-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-2 python2-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-2.7 python3-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-3 python3-pifpaf.noarch: W: no-manual-page-for-binary pifpaf-3.5 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Requires -------- python2-pifpaf (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-cliff python-fixtures python-pbr python-six python-stevedore pyxattr python3-pifpaf (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-cliff python3-fixtures python3-pbr python3-pyxattr python3-six python3-stevedore Provides -------- python2-pifpaf: python-pifpaf python2-pifpaf python2.7dist(pifpaf) python2dist(pifpaf) python3-pifpaf: python3-pifpaf python3.5dist(pifpaf) python3dist(pifpaf) Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1349578 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thanks Haikel. Addressed the Source0 issue. Please check the updated: Spec URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf.spec SRPM URL: https://pkilambi.fedorapeople.org/python-pifpaf/python-pifpaf-0.12.0-1.fc24.src.rpm
Branches were created in error, as this is not approved yet. I've orphaned them, please contact me or someone else in rel-eng to change ownership once approved.
Done
python-pifpaf-0.12.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-49b6dd041b
python-pifpaf-0.12.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fdbff5ef0
python-pifpaf-0.12.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fdbff5ef0
python-pifpaf-0.12.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-49b6dd041b
python-pifpaf-0.24.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a49c5c32ff
python-pifpaf-0.24.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a49c5c32ff