Bug 1349711 - [Granular entry sh] - Implement renaming of indices in index translator
Summary: [Granular entry sh] - Implement renaming of indices in index translator
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: index
Version: 3.8.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On: 1331323
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-24 05:21 UTC by Krutika Dhananjay
Modified: 2016-07-08 14:43 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1331323
Environment:
Last Closed: 2016-07-08 14:43:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2016-06-24 05:21:33 UTC
+++ This bug was initially created as a clone of Bug #1331323 +++

Description of problem:

In a replicated setup, with the granular entry self-heal feature, when a directory tree is created and deleted while a replica was offline, index translator would need to remove the directory index (or move it into landfill so the janitor thread can pick it up).


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-06-16 06:36:04 EDT ---

REVIEW: http://review.gluster.org/14742 (features/index: Do deletion of name-index in unwind path) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-06-23 04:06:17 EDT ---

REVIEW: http://review.gluster.org/14742 (features/index: Do deletion of name-index in unwind path) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-06-23 04:06:20 EDT ---

REVIEW: http://review.gluster.org/14781 (features/index: Delete parent dir indices when heal on it is complete) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-06-24 00:14:12 EDT ---

COMMIT: http://review.gluster.org/14742 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 59523a782d7ed00b31c8cdf8da74310384272355
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Jun 15 16:02:44 2016 +0530

    features/index: Do deletion of name-index in unwind path
    
    Previously the deletion of name index was being done before
    winding the xattrop to posix. This order needs to be changed
    to ensure we don't lose the index in the event the xattrop fails
    in posix xl.
    
    Change-Id: I4aa892b102cbf5269cede041b871064563cb7348
    BUG: 1331323
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14742
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Vijay Bellur 2016-06-24 05:23:06 UTC
REVIEW: http://review.gluster.org/14787 (features/index: Do deletion of name-index in unwind path) posted (#1) for review on release-3.8 by Krutika Dhananjay (kdhananj)

Comment 2 Krutika Dhananjay 2016-06-24 05:24:47 UTC
Sent first of the three patches needed to fix this issue.
Moving the bug state to POST.

Comment 3 Vijay Bellur 2016-06-28 10:47:07 UTC
COMMIT: http://review.gluster.org/14787 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) 
------
commit 2fe7b9ddefd33d64e601254bbf740b24e2b85469
Author: Krutika Dhananjay <kdhananj>
Date:   Wed Jun 15 16:02:44 2016 +0530

    features/index: Do deletion of name-index in unwind path
    
            Backport of: http://review.gluster.org/14742
    
    Previously the deletion of name index was being done before
    winding the xattrop to posix. This order needs to be changed
    to ensure we don't lose the index in the event the xattrop fails
    in posix xl.
    
    Change-Id: If0d713645858c9dce6d4a9c5d9ea27ccb0cfa29f
    BUG: 1349711
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14787
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Ravishankar N <ravishankar>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 4 Niels de Vos 2016-07-08 14:43:16 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.1, please open a new bug report.

glusterfs-3.8.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/156
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.