Description of problem: Version-Release number of selected component (if applicable): 5.6.0.12 How reproducible: Always Steps to Reproduce: 1. Compute -> Infrastructure -> Datastores 2. Select a filter and click on clear 3. Now in All datastores Datastores select advanced search 4. Exit that advanced search Actual results: Clear link appears next to All datastores Datastores Expected results: No clear button should appear Additional info:
Eric, Can you investigate and see what is making "Clear" link to appear even when user has not applied any filters. Can you check to see if same issue exists on any of the other list views. Thanks, ~Harpreet
My current theory is that the filters are not properly cleared after step 2. Then the clear_search_show_or_hide method is returning true here: https://github.com/ManageIQ/manageiq/blob/master/app/controllers/application_controller/filter.rb#L468 —causing the clear_search link to appear. I could not reproduce it on other list views with advanced search. Investigating whether the answer lies in one of these other views.
https://github.com/ManageIQ/manageiq/pull/9494
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/308143763c529325973e6549c1f23801151f4fb8 commit 308143763c529325973e6549c1f23801151f4fb8 Author: Eric Hayes <eric> AuthorDate: Tue Jun 28 10:13:55 2016 -0700 Commit: Eric Hayes <eric> CommitDate: Tue Jun 28 10:46:08 2016 -0700 Properly clear search for Datastores filters Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1349894 https://bugzilla.redhat.com/show_bug.cgi?id=1349888 app/controllers/application_controller/filter.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Verified in 5.7.0.3. No clear link appeared.