Bug 1349991 - [RFE] UI: Clean up credentials validation in the Provider forms
Summary: [RFE] UI: Clean up credentials validation in the Provider forms
Keywords:
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.6.5
Assignee: Aparna Karve
QA Contact: Ramesh A
URL:
Whiteboard: ui:provider:validation
Depends On: 1349975 1361045
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-24 18:29 UTC by John Prause
Modified: 2017-11-08 17:40 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1349975
Environment:
Last Closed: 2017-11-08 17:40:52 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 2 CFME Bot 2016-07-13 19:05:53 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/5db687377edef412a7a2b497d03aece2f50ab97c

commit 5db687377edef412a7a2b497d03aece2f50ab97c
Author:     Aparna Karve <akarve>
AuthorDate: Thu Jul 7 16:47:09 2016 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Wed Jul 13 11:08:21 2016 -0700

    For hawkular and metrics skip revalidation under certain conditions
    
    For e.g. - A condition where hostname is blank and api_port changes
    https://bugzilla.redhat.com/show_bug.cgi?id=1349991

 .../ems_common/ems_common_form_controller.js       |  5 +++++
 .../validation/reset_validation_status.js          |  7 ++++++-
 .../angular-bootstrap/_endpoints_angular.html.haml | 23 +++++++++++-----------
 3 files changed, 23 insertions(+), 12 deletions(-)

Comment 4 Ramesh A 2016-08-01 12:52:29 UTC
Good to go. Verified and working fine in 5.6.1.0.20160726144018_810a94f.

Now appliance exhibits following behavior
1. Required field is highlighted with two ways
    a. The textbox or dropdown field is highlighed with red border
    b. Below the required text field, "Required" text is displayed in Red color font
2. Validate button gets enabled only when all the relevant details are filled out
3. "Validation Required" text is displayed once the "Validate" button is enabled, promting user to validate the provider details.  Save button is disabled.
3. For unsuccessful validation, Validate button remains enabled and Add button disabled
4. Add button is not enabled unless provider validation is successful
5. While adding/editing a cloud or infra provider, an icon with red color indication is displayed for the tab which has required fields.
6. While editing an infra/cloud provider, any changes made to say IP, Host Name, Port, credentials, etc... invalidates the previous validation and prompts user to re-validate the new data

Comment 8 Aparna Karve 2016-08-12 18:33:58 UTC
Leo, currently changing the Region does not require a revalidation -- but you're right since the pricing may be different for different regions, credentials validated for one region may not be valid for the other.
I'd be fixing that.

Thanks,
Aparna

Comment 10 CFME Bot 2016-08-18 09:31:14 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/7903dd05d14816594124f11ede39337f1df94881

commit 7903dd05d14816594124f11ede39337f1df94881
Author:     Aparna Karve <akarve>
AuthorDate: Tue Aug 16 14:13:17 2016 -0700
Commit:     Aparna Karve <akarve>
CommitDate: Tue Aug 16 14:23:21 2016 -0700

    Change in Region should trigger revalidation of credentials
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1349991

 .../javascripts/controllers/ems_common/ems_common_form_controller.js  | 3 ++-
 app/views/shared/views/ems_common/angular/_form.html.haml             | 4 +++-
 2 files changed, 5 insertions(+), 2 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.