Created attachment 1172428 [details] mprdcfmeas326
Created attachment 1172429 [details] evm_current_mprdcfmews356.corp.intuit.net_20160625_161410.tgz
Created attachment 1172590 [details] service dialogs yaml
It was determined that if a single filter exists for an object type (Cluster, Host, Storage) the provisioning workflow will automatically select the filter. In this case the filter required user input and therefore failed to run which caused the provision request being created over web-services to fail. To work-around the issue we remove the filter on Infrastructure -> Cluster. There are currently two ways to avoid this issue: 1) Ensure you do not have exactly one filter. Either delete the filter or create a second one. (Note: If you specify a filter as your default filter it will also be used by default in the provision dialogs.) 2) Modify the dialog section for filters so the filters do not get loaded. This would require removing the "values_from" section of the dialog field hash. Example (From miq_provision_vmware_dialogs_template.yaml) :cluster_filter: :values_from: :options: :category: :EmsCluster :method: :allowed_filters :auto_select_single: false :description: Filter :required: false :display: :edit :data_type: :integer Could be changed to: :cluster_filter: :auto_select_single: false :description: Filter :required: false :display: :hide :data_type: :integer Colin - Please provide this information to the customer and let me know if you have any questions. Also, I am dropping this issue to medium, please adjust the severity if you feel this is incorrect.
Lucy - We need to determine why the workflow is auto-selecting the filter when there is only one. At the moment I am not sure where this is coming from as the fields have ":auto_select_single: false". Also, I would like to understand where the default filter is being selected as I do not think that is the functionality we want in the provisioning dialogs. Ping me and we can discuss.
Lucy, https://github.com/ManageIQ/manageiq/blob/ce67a8e004b31e07c15fe4a3c1bde855170fe7fe/app/views/miq_request/_prov_field.html.haml#L32 is only checking if back-end has set options[field] where field is :cluster_filter and options is all the values set by back-end based upon workflow object, if option[field] is set UI uses it's first element to show as selected item in the drop down, in my case options[field] is being set to [1000000000144, \"Some filter name\"] by model code here https://github.com/ManageIQ/manageiq/blob/ce67a8e004b31e07c15fe4a3c1bde855170fe7fe/app/models/miq_request_workflow.rb#L155 https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_provision_virt_workflow.rb#L319 is setting default filter to be displayed as selected filter in the UI Let me know if you need assistance looking into this. Thanks, ~Harpreet
https://github.com/ManageIQ/manageiq/pull/9951
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/831f831a5075852b00da0ffcc354c8c87a7a4b5c commit 831f831a5075852b00da0ffcc354c8c87a7a4b5c Author: Lucy Fu <lufu> AuthorDate: Tue Jul 19 09:26:32 2016 -0400 Commit: Lucy Fu <lufu> CommitDate: Thu Jul 21 15:54:30 2016 -0400 The single value should not be auto-selected as the default. Method get_field would set the default based on the value of auto_select_single and that result should not be overwritten here. https://bugzilla.redhat.com/show_bug.cgi?id=1350115 app/models/miq_request_workflow.rb | 5 ----- spec/models/miq_request_workflow_spec.rb | 36 ++++++++++++++++++++++++++------ 2 files changed, 30 insertions(+), 11 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/e7e75fd2f41bae5f22c78b4a9ffc79dcb0813b23 commit e7e75fd2f41bae5f22c78b4a9ffc79dcb0813b23 Author: Lucy Fu <lufu> AuthorDate: Thu Jul 21 15:54:01 2016 -0400 Commit: Lucy Fu <lufu> CommitDate: Thu Jul 21 15:54:30 2016 -0400 Remove setting the default filters. Remove setting the default filters which is not really needed and it will only cause issues for provision requests made through automate or REST https://bugzilla.redhat.com/show_bug.cgi?id=1350115 app/models/miq_provision_virt_workflow.rb | 15 --------------- 1 file changed, 15 deletions(-)