Spec URL: https://download.nohats.ca/perl-Net-IP-XS/perl-Net-IP-XS.spec
SRPM URL: https://download.nohats.ca/perl-Net-IP-XS/perl-Net-IP-XS-0.17-1.fc24.src.rpm
Description: An XS (C) implementation of Net::IP. See Net::IP's documentation (as at version 1.25) for the functions and methods that are available.

Fedora Account System Username: pwouters

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Paul, are you still interested in this package? The latest upstream version is 0.21 now. Could you please update your package?

Closing this review for no response from the submitter.

Yes, I'm still interested, but no one has committed to doing a review yet. If you want to review it, please assign the bug to yourself. I will update the package to the latest version.

SPEC: https://download.nohats.ca/perl-Net-IP-XS/perl-Net-IP-XS.spec
SRPM: https://download.nohats.ca/perl-Net-IP-XS/perl-Net-IP-XS-0.21-1.fc33.src.rpm

The URL and Source0 addresses are usable. Ok.
TODO: Replace URL and Source0 addresses with Metacpan server (See where the current URL redirects and where the Download link points to).

Source0 archive (SHA-256: ae9194101adaee050c342475b1ed6674b66cfa1d35fced59d994ae4b34123e78) is original. Ok.
Summary verified from (lib/Net/IP/XS.pm). Ok.
Description verified from (lib/Net/IP/XS.pm). Ok.

License verified from: n128.h (GPLv2+), inet_pton.h (GPLv2+ and MIT), functions.c (GPLv2+), LICENSE (GPLv2 text), object.c (GPLv2+), README (GPLv2+), NetIpXs.xs (GPLv2+), functions.h (GPLv2+), lib/Net/IP/XS.pm (GPLv2+), object.h (GPLv2+), n128.c (GPLv2+), inet_pton.c (GPLv2+ and MIT).
FIX: Change License tag from "GPLv2" to "GPLv2+ and MIT".

TODO: Remove Group tag. It's obsolete.
TODO: Use "perl" instead of %{__perl} macro. Under-scored macros are not intended for a public use.
TODO: Add NO_PACKLIST=1 NO_PERLLOCAL=1 arguments to "perl Makefile.PL" command, constrain perl(ExtUtils::MakeMaker) with ">= 6.76" version, use %{make_build} instead of 
"make %{?_smp_mflags}", use %{make_install} instead of "make pure_install", remove all the find commands except of "*.bs" line. See <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker> for an example.
TODO: Remove "rm -rf %{buildroot}" from %install section. It's obsolete.
TODO: Remove %clean section. It's obsolete.
FIX: Package LICENSE file with %license macro.

FIX: Own %{perl_vendorarch}/auto/Net/IP directory. I recommend:
%{perl_vendorarch}/Net*
%{perl_vendorarch}/auto/*

FIX: Build-require "gcc" for compiling this XS module.
FIX: Build-require "make" (perl-Net-IP-XS.spec:31).
FIX: Build-require "findutils" (perl-Net-IP-XS.spec:39).
FIX: Build-require "coreutils" (perl-Net-IP-XS.spec:42).

FIX: Build-require all used Perl modules:
perl(ExtUtils::MakeMaker::Config) at Makefile.PL:5
perl(strict) at Makefile.PL:1
perl(warnings) at Makefile.PL:2
perl(base) at lib/Net/IP/XS.pm:63
perl(DynaLoader) at lib/Net/IP/XS.pm:63
perl(Exporter) at lib/Net/IP/XS.pm:63
perl(overload) at lib/Net/IP/XS.pm:58
perl(Config) at t/50-rt-102155.t:6
perl(File::Temp) at t/41-serialise.t:9
perl(if) at t/50-rt-102155.t:7
perl(Scalar::Util) at t/40-objects.t:13
perl(Storable) at t/41-serialise.t:8
perl(threads) at t/50-rt-102155.t:7

Run-require perl(IP::Authority) (lib/Net/IP/XS.pm:174).

FIX: This package fails to build because perl(IP::Authority) is not available in Fedora 35.

Please correct all FIX issues, consider fixing  TODO items, and provide a new spec file.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Bugzilla claims that the submitter's account was closed.