Bug 1350625 - heketi-cli topology command quits when error is found without informing the user the reason
Summary: heketi-cli topology command quits when error is found without informing the u...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: heketi
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: RHGS Container Converged 1.0
Assignee: Luis Pabón
QA Contact: Bala Konda Reddy M
URL:
Whiteboard:
: 1351439 (view as bug list)
Depends On:
Blocks: 1332128
TreeView+ depends on / blocked
 
Reported: 2016-06-27 23:38 UTC by Luis Pabón
Modified: 2016-11-08 22:25 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-04 04:51:38 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1498 0 normal SHIPPED_LIVE heketi update for Red Hat Gluster Storage 3.1 2016-08-04 08:49:19 UTC

Description Luis Pabón 2016-06-27 23:38:12 UTC
Description of problem:


Output:
$ heketi-cli -s http://deploy-heketi-default.cloudapps.example.com topology load --json=glusterfs-node-topology.json
Creating cluster ... ID: 0c155e521ba0c8b09793185604eea7fe
	Creating node 192.168.10.100 ... ID: aeacb754f9c1054ec8bdd196e4a662ef
		Adding device /dev/vdb ...
$

Version-Release number of selected component (if applicable):
2.0.2-3

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Luis Pabón 2016-07-06 16:23:54 UTC
https://github.com/heketi/heketi/issues/414

Comment 3 Luis Pabón 2016-07-06 16:42:43 UTC
*** Bug 1351439 has been marked as a duplicate of this bug. ***

Comment 5 Bhaskarakiran 2016-07-13 06:14:28 UTC
The topology load is failing every time. Heketi build that is used is 2.0.2-3. Docker logs of the heketi container shows below message and there is no way to get around this. We would need the fix ASAP.

[kubeexec] ERROR 2016/07/13 01:58:59 /src/github.com/heketi/heketi/executors/kubeexec/kubeexec.go:298: Failed to run command [sudo pvcreate --metadatasize=128M --dataalignment=256K /dev/vdb] on glusterfs-dc-dhcp41-221.lab.eng.blr.redhat.com-1-kr66s: Err[Error executing remote command: Error executing command in container: Error executing in Docker Container: 1]: Stdout []: Stderr [sudo: sorry, you must have a tty to run sudo


There is blocker+ already for this bug.

Comment 6 Luis Pabón 2016-07-13 13:17:09 UTC
(In reply to Bhaskarakiran from comment #5)
> The topology load is failing every time. Heketi build that is used is
> 2.0.2-3. Docker logs of the heketi container shows below message and there
> is no way to get around this. We would need the fix ASAP.
> 
> [kubeexec] ERROR 2016/07/13 01:58:59
> /src/github.com/heketi/heketi/executors/kubeexec/kubeexec.go:298: Failed to
> run command [sudo pvcreate --metadatasize=128M --dataalignment=256K
> /dev/vdb] on glusterfs-dc-dhcp41-221.lab.eng.blr.redhat.com-1-kr66s:
> Err[Error executing remote command: Error executing command in container:
> Error executing in Docker Container: 1]: Stdout []: Stderr [sudo: sorry, you
> must have a tty to run sudo
> 
> 
> There is blocker+ already for this bug.

This is due to BZ 1353497, not this one.

Comment 9 Bala Konda Reddy M 2016-07-24 09:45:59 UTC
Showing the user proper error message when topology load fails.
Topology is loading successfully.

Expected : when wrong device is given for the first node, it should fail for the first node (should show proper error message) and continue with other nodes

[root@dhcp37-213 ~]# heketi-cli topology load --json=topology.json
Creating cluster ... ID: a32aea6cf6cbbdc37a27bb69a548cd6e
	Creating node dhcp37-208.lab.eng.blr.redhat.com ... ID: d29f154367abf0daf84f7b9dc19f1a8d
		Adding device /dev/vd ... Unable to add device: Unable to execute command on glusterfs-dc-dhcp37-208.lab.eng.blr.redhat.com-1-zn3yk:   Device /dev/vd not found (or ignored by filtering).


	Creating node dhcp37-200.lab.eng.blr.redhat.com ... ID: a0cf706a79bb1a4666fa53e2b58c1cad
		Adding device /dev/vdc ... OK
	Creating node dhcp37-204.lab.eng.blr.redhat.com ... ID: 4538c22d4c213a7bc503678eb2007620
		Adding device /dev/vdc ... OK


Later the topology file is edited with correct device then the topology load is successful and the device is added to the node.

[root@dhcp37-213 ~]# heketi-cli topology load --json=topology.json
	Found node dhcp37-208.lab.eng.blr.redhat.com on cluster a32aea6cf6cbbdc37a27bb69a548cd6e
		Adding device /dev/vdc ... OK
	Found node dhcp37-200.lab.eng.blr.redhat.com on cluster a32aea6cf6cbbdc37a27bb69a548cd6e
		Found device /dev/vdc
	Found node dhcp37-204.lab.eng.blr.redhat.com on cluster a32aea6cf6cbbdc37a27bb69a548cd6e
		Found device /dev/vdc

Hence Marking it as verified

Comment 11 errata-xmlrpc 2016-08-04 04:51:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1498.html


Note You need to log in before you can comment on or make changes to this bug.