Bug 1350816 - proc.psinfo.rss is incorrect with threads enabled
Summary: proc.psinfo.rss is incorrect with threads enabled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pcp
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nathan Scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-06-28 13:08 UTC by Marko Myllynen
Modified: 2016-09-06 02:19 UTC (History)
8 users (show)

Fixed In Version: pcp-3.11.4-1.el5 pcp-3.11.4-1.fc24 pcp-3.11.4-1.fc23
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-05 19:48:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Marko Myllynen 2016-06-28 13:08:07 UTC
Description of problem:
When using -L with pmdaproc threads are listed as expected for proc.psinfo.pid and others. However, at least for proc.psinfo.rss some values reported are impossible:

$ top -b -n 1 | grep firefox
 7855 testuser  20   0 2027664 661412  69580 S   0.0  8.4  14:42.15 firefox
$ pminfo -f proc.psinfo.rss | grep firefox        
    inst [7855 or "007855 /usr/lib64/firefox/firefox"] value 660672
    inst [7872 or "007872 /usr/lib64/firefox/firefox"] value 660672
    inst [7873 or "007873 /usr/lib64/firefox/firefox"] value 4008509440
    inst [7874 or "007874 /usr/lib64/firefox/firefox"] value 4008509440
    inst [7875 or "007875 /usr/lib64/firefox/firefox"] value 4008509440
    inst [7876 or "007876 /usr/lib64/firefox/firefox"] value 4008509440
    inst [7877 or "007877 /usr/lib64/firefox/firefox"] value 4008509440
    inst [7878 or "007878 /usr/lib64/firefox/firefox"] value 4008509440
...

First observed by lukas` on IRC.

Comment 1 Nathan Scott 2016-06-29 01:48:50 UTC
Pretty sure this is related to the command field in files like /proc/pid/[task/]stat containing whitespace - certainly several of the firefox threads on my local system show this behavior anyway, and its definitely confusing the code.

I'm pushing a fix for that into pcp git now, but it'd be good to confirm the contents of some of the thread procfs files from one of your affected systems too Marko/Lukas - thanks.

Comment 2 Marko Myllynen 2016-06-29 08:50:31 UTC
The patch fixes the issue for me. Thanks!

Comment 3 Fedora Update System 2016-08-14 22:53:19 UTC
pcp-3.11.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-415f0c78ed

Comment 4 Fedora Update System 2016-08-14 22:53:35 UTC
pcp-3.11.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b76275250f

Comment 5 Fedora Update System 2016-08-14 22:53:51 UTC
pcp-3.11.4-1.el5 has been submitted as an update to Fedora EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a51156083f

Comment 6 Fedora Update System 2016-08-16 01:55:13 UTC
pcp-3.11.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b76275250f

Comment 7 Fedora Update System 2016-08-16 05:16:14 UTC
pcp-3.11.4-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a51156083f

Comment 8 Fedora Update System 2016-08-16 05:56:27 UTC
pcp-3.11.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-415f0c78ed

Comment 9 Fedora Update System 2016-09-05 19:48:20 UTC
pcp-3.11.4-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-09-05 22:53:05 UTC
pcp-3.11.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-09-06 02:19:32 UTC
pcp-3.11.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.