Description of problem: After upgrading tcsh from tcsh-6.19.00-3.fc23.x86_64 to tcsh-6.19.00-9.fc24.x86_64, multi-line prompt is not treated correctly in command line editing. I found the following patch might make the problem. tcsh-6.19.00-007-fix-handling-of-invalid-unicode-characters.patch But I do not know how to fix it. Version-Release number of selected component (if applicable): tcsh-6.19.00-9.fc24.x86_64 How reproducible: Every time Steps to Reproduce: 1. cd ~ 2. set prompt="%~\n%%" 3. ctrl-p, ctrl-u Actual results: ~ %se Expected results: ~ %
Created attachment 1175756 [details] Patch to fix the problem of determination of NLSClass This proposed patch determines whether a character is a control code at the first in NLSClassify(). Function NLSClassify() never returns NLSCLASS_NL, NLSCLASS_TAB and NLSCLASS_CTRL when drawPrompt flag is true unless this patch is applied.
Thank you for the patch, Kensuke. Have you proposed this patch to upstream yet? If not, would you like to do it, or should I do it on your behalf? :) Best regards, Dee'Kej
I have not proposed it to upstream yet. Would you please propose it on my befalf? Best regards, Kensuke IWAHASHI
Sure, no problem. I will do it. :)
So, as you have probably already noticed, I have contacted upstream: http://mx.gw.com/pipermail/tcsh-bugs/2016-July/001071.html Lets see what they have to say about this... :)
Upstream has accepted the patch, I have submitted it into git: http://pkgs.fedoraproject.org/cgit/rpms/tcsh.git/commit/?id=ae5f8a98adbe I will add the build into bodhi tomorrow, so you can test it. (I'm sorry, I have to leave work now.)
tcsh-6.19.00-10.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6666b3570
Thank you for fixing this problem. It works fine.
If it (does not) works for you, please make an unpdate in Bodhi by adding +/-1 to karma. Once it has enough positive karma, it should be pushed from testing to stable automatically... ;)
tcsh-6.19.00-10.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e6666b3570
tcsh-6.19.00-10.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.