Bug 1351109
| Summary: | Addition of new hosted-engine host via REST-API parameter is missing. | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Nikolai Sednev <nsednev> |
| Component: | BLL.HostedEngine | Assignee: | Roy Golan <rgolan> |
| Status: | CLOSED WORKSFORME | QA Contact: | meital avital <mavital> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.0.0 | CC: | bugs, dfediuck, msivak, nsednev, rgolan, stirabos, ylavi |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | Flags: | ylavi:
ovirt-4.0.z?
rule-engine: planning_ack? rule-engine: devel_ack? rule-engine: testing_ack? |
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-30 14:05:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | SLA | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1200469 | ||
|
Description
Nikolai Sednev
2016-06-29 09:36:14 UTC
I am not sure you all properly understand what is written in the bug. It is possible to request hosted engine deploy just fine, but the argument is passed using the URL (/api/hosts;hosted_engine_deploy=true) and not inside the request body host object. This is a valid pattern in our REST API. Now, personally I think it is wrong to do it like this too, but this is definitely not High severity as High is defined in BZ help as: high-impact issues in which the customer's operation is disrupted, but there is some capacity to produce. And that is not the case at all. This is a cosmetic issue where the argument is passed out of the main object. I am reducing the severity based on this. This is a part of API design. The request to deploy a host or undeploy is not and attribute of the host, and that's not going to change. Also, there is no way to interact with the API without authentication. Unless I'm missing something this bug will be closed by EOD (In reply to Roy Golan from comment #5) > This is a part of API design. The request to deploy a host or undeploy is > not and attribute of the host, and that's not going to change. > > Also, there is no way to interact with the API without authentication. > > Unless I'm missing something this bug will be closed by EOD My point was only that I'd rather would like to use deploy as a parameter than as continuation of an URL, if that is by design, please close the bug. (In reply to Roy Golan from comment #5) > This is a part of API design. The request to deploy a host or undeploy is > not and attribute of the host, and that's not going to change. We should consider it though. REST is about state transfer, so we should interpret a provided HE host flag or HE score field as a request to deploy with HE support to be consistent. Nobody expect an additional argument for POST to be passed in the URL. I have only seen this approach used to control the amount of information (additional subcollections, filtering..), but never to trigger an action. > Also, there is no way to interact with the API without authentication. Correct. Nikolai, you logged in to the api using HTTP Basic auth and the browser remembers that. Try accessing the url without the deploy part or do GET and see. It will still work. > Unless I'm missing something this bug will be closed by EOD I agree, this is not a bug at all. Works by design. |