Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1351208

Summary:	the hotpluggable fields are checked only if there are some which are not hotpluggable
Product:	[oVirt] ovirt-engine	Reporter:	Tomas Jelinek <tjelinek>
Component:	Frontend.WebAdmin	Assignee:	jniederm
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lucie Leistnerova <lleistne>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.0.0	CC:	bugs, lsvaty
Target Milestone:	ovirt-4.1.0-alpha	Flags:	rule-engine: ovirt-4.1+ rule-engine: planning_ack+ tjelinek: devel_ack+ lsvaty: testing_ack+
Target Release:	4.1.0.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-01 14:40:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Jelinek 2016-06-29 13:18:34 UTC

in webadmin have a running VM:
- edit the VM and change the memory (this will change also the min allocated memory)
- save
- the dialog asking if the memory change is supposed to be hotplugged or not will pop up (correct)
- press cancel and close the dialog
- open it again
- edit the memory (this will change also the min allocated memory) 
- change the min allocated memory back to the same as it is was defined on the VM
- press ok
- no dialog pops up (problem)

Additional info:
- the issue seems to be in the VmListModel.updateVM() which asks for the getVmChangedFieldsForNextRun(). This call returns only fields which can not be hotplugged (for example the min allocated memory). The checks which ask for the memory hotplug are in the callback and only in case the returned set of changed fields is not empty. This is I'd say incorrect, the check about the hotpluggable fields should be performed regardless of the fact if there are fields which are not hotpluggable.

Comment 1 Sandro Bonazzola 2016-12-12 13:59:30 UTC

The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 2 Lucie Leistnerova 2017-01-16 15:28:12 UTC

changing Physical Memory Guaranteed to previous value doesn't affect showing the confirmation dialog

verified in ovirt-engine-webadmin-portal-
4.1.0-0.4.master.20170115141203.git30e806b.el7.centos.noarch