Bug 1351210 - Type Template/VM filter under VMs is useless
Summary: Type Template/VM filter under VMs is useless
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.0
Assignee: Hilda Stastna
QA Contact: Matouš Mojžíš
URL:
Whiteboard: ui:filter
Depends On:
Blocks: 1371981
TreeView+ depends on / blocked
 
Reported: 2016-06-29 13:20 UTC by Matouš Mojžíš
Modified: 2017-01-12 05:11 UTC (History)
6 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1371981 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:28:54 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Matouš Mojžíš 2016-06-29 13:20:53 UTC
Description of problem:
In VMs filters are Type/Template Type/VMs, which make no sense, because in tree view are VMs and Templates filters separated.

Version-Release number of selected component (if applicable):
5.6.0.13

How reproducible:
Always

Steps to Reproduce:
1. Compute-> Infrastructure-> Virtual Machines -> VMs
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Hilda Stastna 2016-07-12 12:23:28 UTC
https://github.com/ManageIQ/manageiq/pull/9746

Comment 6 CFME Bot 2016-08-23 21:01:16 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/0762cea0159e9ce441f6159430f706d389fb08f2

commit 0762cea0159e9ce441f6159430f706d389fb08f2
Author:     Hilda Stastna <hstastna>
AuthorDate: Wed Jul 13 14:49:23 2016 +0200
Commit:     Hilda Stastna <hstastna>
CommitDate: Tue Aug 2 15:19:49 2016 +0200

    Remove filters Type / Template/VMs from yml file
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1351210
    
    It is removed from db/fixtures/miq_searches.yml
    because the filters are not needed in VMs filters
    anymore. They were seeded in MiqSearch table.
    
    (cherry picked from commit e14faac0c19e9ec9e60b58dc3714adfd7e3adf2a)

 db/fixtures/miq_searches.yml | 21 ---------------------
 1 file changed, 21 deletions(-)

Comment 7 CFME Bot 2016-08-25 18:21:15 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c4dd3de9e2259c4aa6f42d1d55ef9f9848ac9923

commit c4dd3de9e2259c4aa6f42d1d55ef9f9848ac9923
Author:     Hilda Stastna <hstastna>
AuthorDate: Wed Jul 13 14:49:23 2016 +0200
Commit:     Hilda Stastna <hstastna>
CommitDate: Thu Aug 25 16:52:17 2016 +0200

    Remove filters Type / Template/VMs from yml file
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1351210
    
    It is removed from db/fixtures/miq_searches.yml
    because the filters are not needed in VMs filters
    anymore. They were seeded in MiqSearch table.

 db/fixtures/miq_searches.yml | 21 ---------------------
 1 file changed, 21 deletions(-)

Comment 8 CFME Bot 2016-08-25 18:21:20 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/fe9599fc8c409c2a00bac20e5381fd8c4f8abd00

commit fe9599fc8c409c2a00bac20e5381fd8c4f8abd00
Author:     Hilda Stastna <hstastna>
AuthorDate: Tue Jul 19 16:58:49 2016 +0200
Commit:     Hilda Stastna <hstastna>
CommitDate: Thu Aug 25 16:52:17 2016 +0200

    Create migration for removing Type / Template/VMs filters
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1351210
    
    Migration for removing Type / Template/VMs filters
    from MiqSearch to fix the bug because the filters
    were useless in VMS filters.

 ...ype_template_and_vms_filters_from_miq_search.rb | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 db/migrate/20160713130940_remove_type_template_and_vms_filters_from_miq_search.rb

Comment 9 CFME Bot 2016-08-25 18:21:25 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/1f4a982f69719b9bc00f08e0568f7a4a283cd9ad

commit 1f4a982f69719b9bc00f08e0568f7a4a283cd9ad
Author:     Hilda Stastna <hstastna>
AuthorDate: Mon Jul 25 15:14:05 2016 +0200
Commit:     Hilda Stastna <hstastna>
CommitDate: Thu Aug 25 16:52:18 2016 +0200

    Create migration test for removing Type / Template/VMs filters
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1351210
    
    Create migration test for removing filters from MiqSearch
    to fix the bug.

 ...emplate_and_vms_filters_from_miq_search_spec.rb | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 spec/migrations/20160713130940_remove_type_template_and_vms_filters_from_miq_search_spec.rb

Comment 10 Hilda Stastna 2016-08-30 15:02:48 UTC
https://github.com/ManageIQ/manageiq/pull/10802

Comment 13 Matouš Mojžíš 2016-09-30 13:24:38 UTC
Verified in 5.7.0.3. Under VMs there are no useless filters.


Note You need to log in before you can comment on or make changes to this bug.