Description: GStreamer Transcoding API SRPM: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder-1.8.0-1.fc24.src.rpm SPEC: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec This is needed by pitivi 0.96. Caveat, this builds and runs but pitivi doesn't see it. Not sure what I'm missing.
Updated packages to fix typedef file placement, pitivi now works. Same URLs.
Here is the review Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "LGPL (v2 or later)", "Unknown or generated". 4 files have unknown license. [Note] These 4 files are generated. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/gstreamer-1.0/gst/transcoder [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/gstreamer-1.0, /usr/lib64/girepository-1.0, /usr/include/gstreamer-1.0/gst, /usr/include/gstreamer-1.0/gst/transcoder, /usr/share/gir-1.0 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [Note] It will be nice upstream renamed the tarball to gst-transcoder [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gst- transcoder-devel , gst-transcoder-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gst-transcoder-1.8.0-1.fc24.x86_64.rpm gst-transcoder-devel-1.8.0-1.fc24.x86_64.rpm gst-transcoder-debuginfo-1.8.0-1.fc24.x86_64.rpm gst-transcoder-1.8.0-1.fc24.src.rpm gst-transcoder.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.x86_64: W: no-documentation gst-transcoder.x86_64: W: no-manual-page-for-binary gst-transcoder-1.0 gst-transcoder-devel.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gst-transcoder-devel.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gst-transcoder-devel.x86_64: W: only-non-binary-in-usr-lib gst-transcoder-devel.x86_64: W: no-documentation gst-transcoder.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.src: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.src:33: W: configure-without-libdir-spec gst-transcoder.src:41: E: hardcoded-library-path in %{buildroot}/usr/lib/girepository-1.0 gst-transcoder.src:40: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 40) 4 packages and 0 specfiles checked; 1 errors, 12 warnings. Please fix the error and warnings. Rpmlint (debuginfo) ------------------- Checking: gst-transcoder-debuginfo-1.8.0-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- gst-transcoder-debuginfo (rpmlib, GLIBC filtered): gst-transcoder (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstpbutils-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgsttranscoder-1.0.so.0()(64bit) rtld(GNU_HASH) gst-transcoder-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gst-transcoder Provides -------- gst-transcoder-debuginfo: gst-transcoder-debuginfo gst-transcoder-debuginfo(x86-64) gst-transcoder: gst-transcoder gst-transcoder(x86-64) gstreamer1(element-transcodebin)()(64bit) gstreamer1(element-uritranscodebin)()(64bit) libgsttranscoder-1.0.so.0()(64bit) libgsttranscoderplugin.so()(64bit) gst-transcoder-devel: gst-transcoder-devel gst-transcoder-devel(x86-64) pkgconfig(gst-transcoder-1.0) Unversioned so-files -------------------- gst-transcoder: /usr/lib64/gstreamer-1.0/libgsttranscoderplugin.so gst-transcoder: /usr/lib64/libgsttranscoder-1.0.so Source checksums ---------------- http://github.com/pitivi/gst-transcoder/archive/1.8.0.tar.gz : CHECKSUM(SHA256) this package : e63923e29f57fd40d9cab75079867a73052c0775705ee3b4abecdcdaa2c9ef45 CHECKSUM(SHA256) upstream package : e63923e29f57fd40d9cab75079867a73052c0775705ee3b4abecdcdaa2c9ef45
Created attachment 1175919 [details] Alternative spec file I moved the logic to copy and remove to %post and %postun to make unstall remove the file correctly.
The problem is really that meson installs the typelib file unconditionally in /usr/lib/
Right, but we shouldn't alter the file payload in post and postun. Additionally, doing so as proposed, using libdir in post, will behave differently on 32 and 62 bit systems. It will also break on 32 bit, as libdir evaluates to /usr/lib.
Ping?
(In reply to Jon Ciesla from comment #6) > Ping? Would you update the spec file once fixing this line: gst-transcoder.src:41: E: hardcoded-library-path in %{buildroot}/usr/lib/girepository-1.0 Thanks.
There isn't, to my knowledge, a macro that evaluates to /usr/lib on 64-bit systems. If there is, I'll use that, but if not, this is necessary.
(In reply to Jon Ciesla from comment #8) > There isn't, to my knowledge, a macro that evaluates to /usr/lib on 64-bit > systems. If there is, I'll use that, but if not, this is necessary. Fair enough. Could you verify the onwnership of these lines" [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/gstreamer-1.0/gst/transcoder [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/gstreamer-1.0, /usr/lib64/girepository-1.0, /usr/include/gstreamer-1.0/gst, /usr/include/gstreamer-1.0/gst/transcoder, /usr/share/gir-1.0 Once they are solved, this package will be approved.
(In reply to Jon Ciesla from comment #8) > There isn't, to my knowledge, a macro that evaluates to /usr/lib on 64-bit > systems. If there is, I'll use that, but if not, this is necessary. %{_prefix}/lib? (In reply to Luya Tshimbalanga from comment #9) > (In reply to Jon Ciesla from comment #8) > > There isn't, to my knowledge, a macro that evaluates to /usr/lib on 64-bit > > systems. If there is, I'll use that, but if not, this is necessary. > > Fair enough. Could you verify the onwnership of these lines" > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/include/gstreamer-1.0/gst/transcoder shoud be trivial to fix > > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/include/gstreamer-1.0, > /usr/lib64/girepository-1.0, /usr/include/gstreamer-1.0/gst, > /usr/include/gstreamer-1.0/gst/transcoder, /usr/share/gir-1.0 should have some requirements on gobject and gstreamer stuff. > > Once they are solved, this package will be approved.
This should do it: SRPM: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder-1.8.0-2.fc24.src.rpm SPEC: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec
> Requires: %{name} = %{version}-%{release} MUST: missing %{?_isa} > %{_datadir}/gir-1.0/ not sure if it's good idea to own gir/typelib directories directly instead of requiring gobject-introspection > %{_libdir}/libgsttranscoder-1.0.so MUST: this should go to -devel > make %{?_smp_mflags} %make_build > ./configure --prefix=/usr MUST: %configure > make install DESTDIR=%{buildroot} %make_install > Requires: gstreamer1-devel MUST: missing %{?_isa}
(In reply to Jon Ciesla from comment #11) > This should do it: > SPEC: > https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec Make sure to update the spec file as well. The link led to the old version. Another small detail in addition comment #11 is to verify this line: "Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path."
(In reply to Igor Gnatenko from comment #12) > > Requires: %{name} = %{version}-%{release} > MUST: missing %{?_isa} Fix > > %{_datadir}/gir-1.0/ > not sure if it's good idea to own gir/typelib directories directly instead > of requiring gobject-introspection This seems to be how other packages with files here do it. > > %{_libdir}/libgsttranscoder-1.0.so > MUST: this should go to -devel > It's required at runtime. > > make %{?_smp_mflags} > %make_build Fixed > > ./configure --prefix=/usr > MUST: %configure The configure macro fails. > > make install DESTDIR=%{buildroot} > %make_install > Fixed > > Requires: gstreamer1-devel > MUST: missing %{?_isa} Fixed. I had updated the spec, and have now as well. SRPM: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder-1.8.0-3.fc24.src.rpm SPEC: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec
(In reply to Jon Ciesla from comment #14) > I had updated the spec, and have now as well. > > SRPM: > https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder-1.8.0-3. > fc24.src.rpm > SPEC: > https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec For the spec files, set %{name} for both URL and Source0 and line 52 like: URL: https://github.com/pitivi/%{name} Source0: http://github.com/pitivi/%{name}/archive/%{version}.tar.gz %{_bindir}/%{name}-1.0 knowing that %{name} is the variable for gst-transcoder For further review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "LGPL (v2 or later)", "Unknown or generated". Comment: Generated files. [x]: License file installed when any subpackage combination is installed. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/girepository-1.0 (gobject-introspection, libxklavier, GConf2, gspell, libgnome-keyring, gdk-pixbuf2, libgtop2, atk, gtk2, gtk3, vte3, gcr, libgee, vte291, gfbgraph, libzapojit, gucharmap-libs, gsound), /usr/share/gir-1.0(gtk2-devel, gtk3-devel, atk-devel, gdk- pixbuf2-devel) That line is conflicting because of the list of owned directory by other packages. I am hesitant to set it as valid. Need explanation for that case. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). Comment: Macro configration failed [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [ x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gst- transcoder-debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gst-transcoder-1.8.0-3.fc24.x86_64.rpm gst-transcoder-devel-1.8.0-3.fc24.x86_64.rpm gst-transcoder-debuginfo-1.8.0-3.fc24.x86_64.rpm gst-transcoder-1.8.0-3.fc24.src.rpm gst-transcoder.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.x86_64: W: no-documentation gst-transcoder.x86_64: W: no-manual-page-for-binary gst-transcoder-1.0 gst-transcoder-devel.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gst-transcoder-devel.x86_64: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gst-transcoder-devel.x86_64: W: only-non-binary-in-usr-lib gst-transcoder-devel.x86_64: W: no-documentation gst-transcoder.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.src: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer gst-transcoder.src:34: W: configure-without-libdir-spec gst-transcoder.src:42: E: hardcoded-library-path in %{buildroot}/usr/lib/girepository-1.0 That part is clarified and assumed as passed. gst-transcoder.src:41: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 41) 4 packages and 0 specfiles checked; 1 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: gst-transcoder-debuginfo-1.8.0-3.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- gst-transcoder-debuginfo (rpmlib, GLIBC filtered): gst-transcoder (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstpbutils-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgsttranscoder-1.0.so.0()(64bit) rtld(GNU_HASH) gst-transcoder-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gst-transcoder(x86-64) gstreamer1-devel Provides -------- gst-transcoder-debuginfo: gst-transcoder-debuginfo gst-transcoder-debuginfo(x86-64) gst-transcoder: gst-transcoder gst-transcoder(x86-64) gstreamer1(element-transcodebin)()(64bit) gstreamer1(element-uritranscodebin)()(64bit) libgsttranscoder-1.0.so.0()(64bit) libgsttranscoderplugin.so()(64bit) gst-transcoder-devel: gst-transcoder-devel gst-transcoder-devel(x86-64) pkgconfig(gst-transcoder-1.0) Unversioned so-files -------------------- gst-transcoder: /usr/lib64/gstreamer-1.0/libgsttranscoderplugin.so gst-transcoder: /usr/lib64/libgsttranscoder-1.0.so Source checksums ---------------- http://github.com/pitivi/gst-transcoder/archive/1.8.0.tar.gz : CHECKSUM(SHA256) this package : e63923e29f57fd40d9cab75079867a73052c0775705ee3b4abecdcdaa2c9ef45 CHECKSUM(SHA256) upstream package : e63923e29f57fd40d9cab75079867a73052c0775705ee3b4abecdcdaa2c9ef45 Once the comments are corrected and if there is no further feedback, the package will be approved.
Changes applied. SRPM: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder-1.8.0-4.fc24.src.rpm SPEC: https://fedorapeople.org/~limb/review/gst-transcoder/gst-transcoder.spec
Skipping all passed review and looking part needed to be fixed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/girepository-1.0 (gobject-introspection, libxklavier, GConf2, gspell, libgnome-keyring, gdk-pixbuf2, libgtop2, atk, gtk2, gtk3, vte3, gcr, libgee, vte291, gfbgraph, libzapojit, gucharmap-libs, gsound), /usr/share/gir-1.0(gtk2-devel, gtk3-devel, atk-devel, gdk- pixbuf2-devel) Comment: after clarification, that line suggests this package is part of a group After reviewing the spec files, this package is now APPROVED.
Excellent, thank you!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gst-transcoder
(In reply to Jon Ciesla from comment #18) > Excellent, thank you! No problem!
gst-transcoder-1.8.0-4.fc24 pitivi-0.96-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a05bb4f419
gst-transcoder-1.8.1-1.fc24, pitivi-0.96-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a05bb4f419
gst-transcoder-1.8.1-1.fc24, pitivi-0.96-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.