Bug 1352171
| Summary: | some files are missing from tarball | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Alois Mahdal <amahdal> | ||||
| Component: | preupgrade-assistant | Assignee: | Petr Hracek <phracek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Alois Mahdal <amahdal> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 6.8 | CC: | amahdal, fkluknav, jmazanek, ovasik, phracek, pstodulk | ||||
| Target Milestone: | rc | Keywords: | Extras, Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | preupgrade-assistant-2.1.8-5.el6 | Doc Type: | No Doc Update | ||||
| Doc Text: |
undefined
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2016-11-04 08:57:46 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1335121 | ||||||
| Attachments: |
|
||||||
Created attachment 1175130 [details]
listing of tarball contents
Well, some files are really missing, and it is expected.
Reason of that is, we would like to have smaller tarball and directory RHEL6_7 is not needed to be in tarball
This is really failure. README should exist
:: [ FAIL ] :: file README is present (Expected 0, got 1)
RHEL6_7 should not be in tarball. We do not want them even.
:: [ FAIL ] :: file RHEL6_7/ is present (Expected 0, got 1)
:: [ FAIL ] :: file RHEL6_7/README is present (Expected 0, got 1)
:: [ FAIL ] :: file RHEL6_7/all-xccdf.xml is present (Expected 0, got 1)
:: [ FAIL ] :: file RHEL6_7/common/ is present (Expected 0, got 1)
This is expected. etc/ is not needed. We have cleanconf, dirtyconf etc.
:: [ FAIL ] :: file etc/ is present (Expected 0, got 1)
This is probably problem with content PkgDowngrades.
:: [ FAIL ] :: file pkgdowngrades/ is present (Expected 0, got 1)
This is probably problem with report generation.It should be fixed with the latest version which will be released soon.
:: [ FAIL ] :: file result-admin.html is present (Expected 0, got 1)
:: [ FAIL ] :: file result-admin.xml is present (Expected 0, got 1)
:: [ FAIL ] :: file result.html is present (Expected 0, got 1)
:: [ FAIL ] :: file result.xml is present (Expected 0, got 1)
:: [ LOG ] :: Duration: 2s
:: [ LOG ] :: Assertions: 11 good, 11 bad
:: [ FAIL ] :: RESULT: check tarball
Just my $0.02 input: >This is probably problem with content PkgDowngrades. > > :: [ FAIL ] :: file pkgdowngrades/ is present (Expected 0, got 1) > That's possible. AFAIK it is used for downloading of packages during pre-upgrade phase of rhelup and doesn't contain anything interesting for user. It's discussable that different path may could be used. (In reply to Petr Hracek from comment #3) > Well, some files are really missing, and it is expected. > > [...] Thanks, I have updated the test so that these files are not expected. Closing the bug so that missing files should not be a part of tarball. (In reply to Petr Hracek from comment #6) > Closing the bug so that missing files should not be a part of tarball. I don't understand; nothing has been fixed here. Fixed by upstream commit https://github.com/upgrades-migrations/preupgrade-assistant/commit/bb8b531bf12005b616af4110b1e55f1ff6926e43 OK, so re-running (TJ#1460890) the same test (with fixes as per comment 4) with preupgrade-assistant-2.1.8-6.el6: :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: [ LOG ] :: check tarball :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::: :: [ PASS ] :: file name determined (Expected 0, got 0) :: [ PASS ] :: file is not empty (Expected 0, got 0) :: [ PASS ] :: file contents are not empty (Expected 0, got 0) :: [ PASS ] :: file layout is nested (Expected 1, got 1) :: [ PASS ] :: shadow and gshadow files are not packed (Expected 1, got 1) :: [ PASS ] :: file README is present (Expected 0, got 0) :: [ PASS ] :: file cleanconf/ is present (Expected 0, got 0) :: [ PASS ] :: file common/ is present (Expected 0, got 0) :: [ PASS ] :: file dirtyconf/ is present (Expected 0, got 0) :: [ PASS ] :: file kickstart/ is present (Expected 0, got 0) :: [ PASS ] :: file noauto_postupgrade.d/ is present (Expected 0, got 0) :: [ PASS ] :: file postupgrade.d/ is present (Expected 0, got 0) :: [ PASS ] :: file preupgrade-scripts/ is present (Expected 0, got 0) :: [ PASS ] :: file result-admin.html is present (Expected 0, got 0) :: [ PASS ] :: file result-admin.xml is present (Expected 0, got 0) :: [ PASS ] :: file result.html is present (Expected 0, got 0) :: [ PASS ] :: file result.xml is present (Expected 0, got 0) :: [ INFO ] :: =====BEGIN FILE tarball_contents.txt===== :: [ INFO ] :: preupg_results-160823021731/ :: [ INFO ] :: preupg_results-160823021731/dirtyconf/ :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/ :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/sysconfig/ :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/sysconfig/init :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/sysconfig/readahead :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/beah_beaker.conf :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/abrt/ :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/abrt/abrt-action-save-package-data.conf :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/pam.d/ :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/pam.d/smartcard-auth :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/pam.d/system-auth :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/pam.d/fingerprint-auth :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/pam.d/password-auth :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/beah.conf :: [ INFO ] :: preupg_results-160823021731/dirtyconf/etc/inittab :: [ INFO ] :: preupg_results-160823021731/kickstart/ :: [ INFO ] :: preupg_results-160823021731/kickstart/default_grouplist-el7 :: [ INFO ] :: preupg_results-160823021731/kickstart/default-optional_grouplist-el7 :: [ INFO ] :: preupg_results-160823021731/kickstart/README :: [ INFO ] :: preupg_results-160823021731/postupgrade.d/ :: [ INFO ] :: preupg_results-160823021731/postupgrade.d/hashed_file :: [ INFO ] :: preupg_results-160823021731/postupgrade.d/z_copy_clean_conf.sh :: [ INFO ] :: preupg_results-160823021731/hooks/ :: [ INFO ] :: preupg_results-160823021731/cleanconf/ :: [ INFO ] :: preupg_results-160823021731/preupgrade-scripts/ :: [ INFO ] :: preupg_results-160823021731/noauto_postupgrade.d/ :: [ INFO ] :: preupg_results-160823021731/result.xml :: [ INFO ] :: preupg_results-160823021731/result-admin.html :: [ INFO ] :: preupg_results-160823021731/result.html :: [ INFO ] :: preupg_results-160823021731/README :: [ INFO ] :: preupg_results-160823021731/result-admin.xml :: [ INFO ] :: preupg_results-160823021731/common/ :: [ INFO ] :: =====END FILE tarball_contents.txt===== :: [ LOG ] :: Duration: 2s :: [ LOG ] :: Assertions: 17 good, 0 bad :: [ PASS ] :: RESULT: check tarball shows that this has been fixed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2616.html |
Description of problem ====================== Many files are missing from tarball entirely: :: [ PASS ] :: file is not empty (Expected 0, got 0) :: [ PASS ] :: file contents are not empty (Expected 0, got 0) :: [ PASS ] :: file layout is nested (Expected 1, got 1) :: [ PASS ] :: shadow and gshadow files are not packed (Expected 1, got 1) :: [ FAIL ] :: file README is present (Expected 0, got 1) :: [ FAIL ] :: file RHEL6_7/ is present (Expected 0, got 1) :: [ FAIL ] :: file RHEL6_7/README is present (Expected 0, got 1) :: [ FAIL ] :: file RHEL6_7/all-xccdf.xml is present (Expected 0, got 1) :: [ FAIL ] :: file RHEL6_7/common/ is present (Expected 0, got 1) :: [ PASS ] :: file cleanconf/ is present (Expected 0, got 0) :: [ PASS ] :: file common/ is present (Expected 0, got 0) :: [ PASS ] :: file dirtyconf/ is present (Expected 0, got 0) :: [ FAIL ] :: file etc/ is present (Expected 0, got 1) :: [ PASS ] :: file kickstart/ is present (Expected 0, got 0) :: [ PASS ] :: file noauto_postupgrade.d/ is present (Expected 0, got 0) :: [ FAIL ] :: file pkgdowngrades/ is present (Expected 0, got 1) :: [ PASS ] :: file postupgrade.d/ is present (Expected 0, got 0) :: [ PASS ] :: file preupgrade-scripts/ is present (Expected 0, got 0) :: [ FAIL ] :: file result-admin.html is present (Expected 0, got 1) :: [ FAIL ] :: file result-admin.xml is present (Expected 0, got 1) :: [ FAIL ] :: file result.html is present (Expected 0, got 1) :: [ FAIL ] :: file result.xml is present (Expected 0, got 1) :: [ INFO ] :: not dumping, file has too many lines (183) and bytes (10405): tarball_contents.txt :: [ INFO ] :: Sending tarball_contents.txt as tarball_contents.txt :: [ LOG ] :: Duration: 2s :: [ LOG ] :: Assertions: 11 good, 11 bad :: [ FAIL ] :: RESULT: check tarball These files *are* present in /root/preupgrade but not in tarballs. Version-Release number of selected component ============================================ preupgrade-assistant-2.1.7.post18-1.el6 preupgrade-assistant-el6toel7-0.6.49-1.el6 reupgrade-assistant-el6toel7-data-0.20160505-1.el6 How reproducible ================ Always Steps to Reproduce ================== 1. run /CoreOS/preupgrade-assistant/6to7/assistant/result-files Actual results ============== Above failures Expected results ================ No failures