Bug 1352466 (aura/di) - Review Request: php-aura-di - Dependency injection container system
Summary: Review Request: php-aura-di - Dependency injection container system
Status: CLOSED ERRATA
Alias: aura/di
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: aura/router 1357393
TreeView+ depends on / blocked
 
Reported: 2016-07-04 08:44 UTC by Remi Collet
Modified: 2016-07-30 18:25 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2016-07-30 18:25:44 UTC
shawn: fedora-review+


Attachments (Terms of Use)
phpcompatinfo-full.log (9.75 KB, text/plain)
2016-07-18 20:36 UTC, Shawn Iwinski
no flags Details
phpcompatinfo-lib.log (5.46 KB, text/plain)
2016-07-18 20:36 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (6.97 KB, text/plain)
2016-07-18 20:37 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2016-07-04 08:44:43 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/571de1a62277e45aa6443b74e4a1d19548993626/php/zend/php-aura-di/php-aura-di.spec
SRPM URL: http://rpms.remirepo.net/SRPMS/php-aura-di-2.2.4-1.remi.src.rpm
Description: 
The Aura.Di package provides a dependency injection container system
with the following features:

* constructor and setter injection
* explicit and implicit auto-resolution of typehinted constructor
  parameter values
* configuration of setters across interfaces and traits
* inheritance of constructor parameter and setter method values
* lazy-loaded services, values, and instances
* instance factories



Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2016-07-18 20:36 UTC
Created attachment 1181284 [details]
phpcompatinfo-full.log

phpCompatInfo version 5.0.0 DB built May 29 2016 15:12:58 CEST

Comment 2 Shawn Iwinski 2016-07-18 20:36 UTC
Created attachment 1181285 [details]
phpcompatinfo-lib.log

phpCompatInfo version 5.0.0 DB built May 29 2016 15:12:58 CEST

Comment 3 Shawn Iwinski 2016-07-18 20:37 UTC
Created attachment 1181286 [details]
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1352466
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Shawn Iwinski 2016-07-18 20:38:23 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove EPEL 5 bits after initial import



No blockers

===== APPROVED =====

Comment 5 Remi Collet 2016-07-19 06:10:20 UTC
Thanks for the review.

New package requested.

Comment 6 Gwyn Ciesla 2016-07-19 15:27:12 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-aura-di

Comment 7 Fedora Update System 2016-07-20 07:01:50 UTC
php-zendframework-zend-expressive-1.0.0-2.fc24 php-zendframework-zend-expressive-aurarouter-1.0.0-2.fc24 php-zendframework-zend-expressive-fastroute-1.2.0-2.fc24 php-zendframework-zend-expressive-helpers-2.0.0-1.fc24 php-zendframework-zend-expressive-platesrenderer-1.1.0-1.fc24 php-zendframework-zend-expressive-router-1.2.0-2.fc24 php-zendframework-zend-expressive-template-1.0.3-2.fc24 php-zendframework-zend-expressive-twigrenderer-1.1.1-1.fc24 php-zendframework-zend-expressive-zendrouter-1.1.0-2.fc24 php-zendframework-zend-expressive-zendviewrenderer-1.1.0-1.fc24 php-zendframework-zend-stratigility-1.2.1-2.fc24 php-aura-router-2.3.0-1.fc24 php-aura-di-2.2.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-715702a930

Comment 8 Fedora Update System 2016-07-21 04:22:10 UTC
php-aura-di-2.2.4-1.fc24, php-aura-router-2.3.0-1.fc24, php-zendframework-zend-expressive-1.0.0-2.fc24, php-zendframework-zend-expressive-aurarouter-1.0.0-2.fc24, php-zendframework-zend-expressive-fastroute-1.2.0-2.fc24, php-zendframework-zend-expressive-helpers-2.0.0-1.fc24, php-zendframework-zend-expressive-platesrenderer-1.1.0-1.fc24, php-zendframework-zend-expressive-router-1.2.0-2.fc24, php-zendframework-zend-expressive-template-1.0.3-2.fc24, php-zendframework-zend-expressive-twigrenderer-1.1.1-1.fc24, php-zendframework-zend-expressive-zendrouter-1.1.0-2.fc24, php-zendframework-zend-expressive-zendviewrenderer-1.1.0-1.fc24, php-zendframework-zend-stratigility-1.2.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-715702a930

Comment 9 Fedora Update System 2016-07-30 18:24:47 UTC
php-aura-di-2.2.4-1.fc24, php-aura-router-2.3.0-1.fc24, php-zendframework-zend-expressive-1.0.0-2.fc24, php-zendframework-zend-expressive-aurarouter-1.0.0-2.fc24, php-zendframework-zend-expressive-fastroute-1.2.0-2.fc24, php-zendframework-zend-expressive-helpers-2.0.0-1.fc24, php-zendframework-zend-expressive-platesrenderer-1.1.0-1.fc24, php-zendframework-zend-expressive-router-1.2.0-2.fc24, php-zendframework-zend-expressive-template-1.0.3-2.fc24, php-zendframework-zend-expressive-twigrenderer-1.1.1-1.fc24, php-zendframework-zend-expressive-zendrouter-1.1.0-2.fc24, php-zendframework-zend-expressive-zendviewrenderer-1.1.0-1.fc24, php-zendframework-zend-stratigility-1.2.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.