Bug 1352761
| Summary: | Virt-manager can't show OS icons of win7/win8/ubuntu guest. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | XiaoyunHu <xiahu> | ||||||||||||||
| Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> | ||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||
| Priority: | medium | ||||||||||||||||
| Version: | 7.3 | CC: | bihan, juzhou, mxie, mzhan, ptoscano, rjones, tzheng, xiaodwan | ||||||||||||||
| Target Milestone: | rc | ||||||||||||||||
| Target Release: | --- | ||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Fixed In Version: | libguestfs-1.32.5-10.el7 | Doc Type: | If docs needed, set a value | ||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||
| Last Closed: | 2016-11-03 18:02:10 UTC | Type: | Bug | ||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
| Embargoed: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 1176237 [details]
ubuntu12.04.log
Created attachment 1176238 [details]
win7.log
Created attachment 1176239 [details]
win8
I have posted patches which fix some issues: https://www.redhat.com/archives/libguestfs/2016-July/msg00012.html https://www.redhat.com/archives/libguestfs/2016-July/msg00013.html Unfortunately virt-manager asks for high quality icons, and none of the guests here have high quality icons, so these patches will *not* change what is shown in virt-manager. https://github.com/virt-manager/virt-manager/blob/master/virtManager/inspection.py#L227 It's the best we can do here as we're not legally allowed to include high quality icons in libguestfs or virt-manager itself. Created attachment 1186277 [details]
Screenshot of virt-manager
Hi rjones, When I try to verify this bug, I find that I can't see the OS icon column in virt-manager (see attachment). I don't know how to make the OS icon to show out. Could you help me? Thanks in advance. Packages installed: virt-manager-1.4.0-1.el7.noarch libvirt-2.0.0-2.el7.x86_64 qemu-kvm-1.5.3-116.el7.x86_64 qemu-kvm-tools-1.5.3-116.el7.x86_64 libguestfs-1.32.6-2.el7.x86_64 ocaml-libguestfs-devel-1.32.6-1.el7.x86_64 libguestfs-rsync-1.32.6-1.el7.x86_64 libguestfs-rescue-1.32.6-1.el7.x86_64 libguestfs-java-devel-1.32.6-1.el7.x86_64 libguestfs-java-1.32.6-1.el7.x86_64 libguestfs-devel-1.32.6-1.el7.x86_64 libguestfs-gfs2-1.32.6-1.el7.x86_64 libguestfs-winsupport-7.2-1.el7.x86_64 libguestfs-javadoc-1.32.6-1.el7.noarch libguestfs-tools-1.32.6-1.el7.noarch libguestfs-gobject-doc-1.32.6-1.el7.noarch libguestfs-man-pages-ja-1.32.6-1.el7.noarch libguestfs-inspect-icons-1.32.6-1.el7.noarch libguestfs-gobject-1.32.6-1.el7.x86_64 libguestfs-man-pages-uk-1.32.6-1.el7.noarch libguestfs-tools-c-1.32.6-1.el7.x86_64 libguestfs-debuginfo-1.32.6-1.el7.x86_64 libguestfs-gobject-devel-1.32.6-1.el7.x86_64 libguestfs-bash-completion-1.32.6-1.el7.noarch libguestfs-xfs-1.32.6-1.el7.x86_64 ocaml-libguestfs-1.32.6-1.el7.x86_64 (In reply to Bin Han from comment #8) > Hi rjones, > When I try to verify this bug, I find that I can't see the OS icon column > in virt-manager (see attachment). I don't know how to make the OS icon to > show out. Could you help me? Thanks in advance. > > Packages installed: > [...] It looks like python-libguestfs is missing, can you please try installing it (and restarting virt-manager)? (In reply to Pino Toscano from comment #9) > (In reply to Bin Han from comment #8) > > Hi rjones, > > When I try to verify this bug, I find that I can't see the OS icon column > > in virt-manager (see attachment). I don't know how to make the OS icon to > > show out. Could you help me? Thanks in advance. > > > > Packages installed: > > [...] > > It looks like python-libguestfs is missing, can you please try installing it > (and restarting virt-manager)? After install python-libguestfs and restart virt-manager, I can see more the tmp vm but still can't see the icon cloumn. Created attachment 1186330 [details]
tm_ vm
See comment 5: "Unfortunately virt-manager asks for high quality icons, and none of the guests here have high quality icons, so these patches will *not* change what is shown in virt-manager." If you want to verify this fix, you'll need to use the virt-inspector program: virt-inspector -a /var/lib/libvirt/images/<DISK.IMG> If it shows an <icon> element containing a bunch of base64 data (actually an encoded PNG file) then it's working. Package Version:
libguestfs-tools-c-1.32.6-1.el7.x86_64
libguestfs-1.32.6-2.el7.x86_64
steps:
[root@dhcp-13-199 build]# virt-inspector -a Win7-64-hvm.raw
<?xml version="1.0"?>
<operatingsystems>
<operatingsystem>
<root>/dev/sda1</root>
<name>windows</name>
<arch>x86_64</arch>
<distro>windows</distro>
<product_name>Windows 7 Home Basic</product_name>
<product_variant>Client</product_variant>
<major_version>6</major_version>
<minor_version>1</minor_version>
<windows_systemroot>/Windows</windows_systemroot>
<windows_current_control_set>ControlSet001</windows_current_control_set>
<hostname>WIN-0LGBLM6T1HM</hostname>
<format>installed</format>
<mountpoints>
<mountpoint dev="/dev/sda1">/</mountpoint>
</mountpoints>
<filesystems>
<filesystem dev="/dev/sda1">
<type>ntfs</type>
<label>OS_Install</label>
<uuid>8A3CD63F3CD6264B</uuid>
</filesystem>
</filesystems>
<drive_mappings>
<drive_mapping name="C">/dev/sda1</drive_mapping>
</drive_mappings>
<applications>
<application>
<name>Red Hat Paravirtualized Xen Drivers for Windows(R)</name>
<display_name>Red Hat Paravirtualized Xen Drivers for Windows(R) 1.3.13</display_name>
<version>1.3.13</version>
<publisher>Red Hat, Inc.</publisher>
<url>http://www.redhat.com</url>
</application>
</applications>
<icon>iVBORw0KGgoAAAANSUhEUgAAADYAAAA3CAIAAADIey4vAAAMo0lEQVRoge2YaViTVxbHMQlb
CCGCW6lVNinIYpURbQcqiiRAWILIIgLKLmEnkAQJa4CELYAJqwIadgFBVkHZEVAQQXZEwQVL
rdpxaVWgdY4ynQ/zzMwzIm0/DOc5H9577/n//ue5yXvfNxEQWI3VWI3VWI3/t0CJIDYqIZXw
KE07oW8cRPQCIOEChkhlPCxBwZ/WG2K9AkrD6ovD4eYR+ZzKntobd9pGHnZNzkHCBQwTK7oP
..................
eJ7CYbbb8Mg6Ek3YL1c0pwvTeg89/Fzo3jziu18h4QKGMAlLwv5npcxoUAwSOF9W4P79HwMO
2/f/pWhpweN1h76trIGbFCkQZx8p5MSBhAspMypMwhIUQBkUf9L5/CkhLCwsIyOjrq4OJxx8
iMYfAi5gCJOysrJQ8Od0thqrsRqrsRr/Ltb851zB+DtwIBrFFstMPwAAAABJRU5ErkJggg==</icon>
</operatingsystem>
</operatingsystems>
Icon element can be shown in result. So verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2576.html |
Created attachment 1176235 [details] Screenshot Description of problem: Virt-manager can't show OS icons of win7/win8/ubuntu guest. Version-Release number of selected component: libvirt-2.0.0-1.el7.x86_64 virt-manager-1.4.0-1.el7.noarch qemu-kvm-1.5.3-116.el7.x86_64 libguestfs-gobject-1.32.5-9.el7.x86_64 libguestfs-devel-1.32.5-9.el7.x86_64 libguestfs-1.32.5-9.el7.x86_64 libguestfs-gobject-devel-1.32.5-9.el7.x86_64 libguestfs-javadoc-1.32.5-9.el7.noarch ocaml-libguestfs-devel-1.32.5-9.el7.x86_64 libguestfs-java-1.32.5-9.el7.x86_64 libguestfs-winsupport-7.2-1.el7.x86_64 libguestfs-tools-c-1.32.5-9.el7.x86_64 libguestfs-rsync-1.32.5-9.el7.x86_64 libguestfs-gfs2-1.32.5-9.el7.x86_64 ocaml-libguestfs-1.32.5-9.el7.x86_64 libguestfs-java-devel-1.32.5-9.el7.x86_64 python-libguestfs-1.32.5-9.el7.x86_64 libguestfs-tools-1.32.5-9.el7.noarch libguestfs-rescue-1.32.5-9.el7.x86_64 ruby-libguestfs-1.32.5-9.el7.x86_64 libguestfs-xfs-1.32.5-9.el7.x86_64 libguestfs-debuginfo-1.32.5-9.el7.x86_64 libguestfs-inspect-icons.noarch 1:1.32.5-9.el7 How reproducible: 100% Steps to Reproduce: 1. Prepare healthy win7/win8/ubuntu12.04/rhel6/rhel7 guest. 2. Launch virt-manager and wait for a while until all new detecting domains removed. It means libguestfs have detected all the guest. 3. Check if OS icons shown before guest's name in virt-manager main window . Actual results: As the attached screenshot shows, 1.Icon display work for RHEL(RHEL6 & RHEL7) 2.Icon display didn't work for Ubuntu/win7/win8. Expected results: 1.Icon display should work for RHEL/Ubuntu guests and certain windows guests (such as XP, win7, win8) . Additional info: 1.I have attached the output of "virt-inspector -v -x -a /var/lib/libvirt/images/DISK.IMG" for each guest's disk image that isn't working.