Spec URL: https://jcline.fedorapeople.org/python-args.spec SRPM URL: https://jcline.fedorapeople.org/python-args-0.1.0-1.fc25.src.rpm Description: Argument Parsing for Humans. FAS username: jcline Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14779437
In general looks good, but there are some issues: > Source0: https://github.com/kennethreitz/%{srcname}/archive/v%{version}.tar.gz Source0: %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz > Summary: %{sum} Just put summary here and use further by %{summary} > BuildRequires: python2-devel python3-devel Put BuildRequires: python2-devel BuildRequires: python2-setuptools under %package -n python2-%{srcname} > %description -n python2-%{srcname} > Argument Parsing for Humans. %description -n python2-%{srcname} %{summary}. Python 2 version. Same for python3. Once will be fixed - we can approve it.
Spec URL: https://jcline.fedorapeople.org/python-args.spec SRPM URL: https://jcline.fedorapeople.org/python-args-0.1.0-2.fc25.src.rpm I'm fine with all these changes, but it's worth noting the packaging guidelines for Python exhibit most of these problems[0]. If these are true blockers for review, I think the guidelines should be updated. [0] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Just one note: > Source0: %{url}/archive/v%{version}.tar.gz Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz Otherwise it is really hard to find for which package belongs tarball.
(In reply to Igor Gnatenko from comment #3) > Just one note: > > Source0: %{url}/archive/v%{version}.tar.gz > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > Otherwise it is really hard to find for which package belongs tarball. Unfortunately that doesn't work because it's not a valid URL. GitHub's archives are available at <repo-url>/archive/<tag-name>.{tar.gz,zip} and upstream uses the tag format `v<version number>`. Thanks for the review!
(In reply to Jeremy Cline from comment #4) > (In reply to Igor Gnatenko from comment #3) > > Just one note: > > > Source0: %{url}/archive/v%{version}.tar.gz > > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > > > Otherwise it is really hard to find for which package belongs tarball. > > Unfortunately that doesn't work because it's not a valid URL. GitHub's > archives are available at <repo-url>/archive/<tag-name>.{tar.gz,zip} and > upstream uses the tag format `v<version number>`. It does. Look below: [brain@x1carbon libhif]$ curl -L -O https://github.com/kennethreitz/args/archive/v0.1.0/python-args-0.1.0.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 125 0 125 0 0 130 0 --:--:-- --:--:-- --:--:-- 130 100 4038 100 4038 0 0 2396 0 0:00:01 0:00:01 --:--:-- 2396 [brain@x1carbon libhif]$ tar xvf python-args-0.1.0.tar.gz args-0.1.0/ args-0.1.0/.gitignore args-0.1.0/LICENSE args-0.1.0/README.rst args-0.1.0/args.py args-0.1.0/setup.py > > Thanks for the review!
Oh interesting. I didn't see the /v%{version}/ in the updated url so my trial run failed. I didn't know you could do that, thanks for the tip.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-args
python-args-0.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-fc0ec2f334
python-args-0.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-aeb9a60b9a
python-args-0.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aeb9a60b9a
python-args-0.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-fc0ec2f334
python-args-0.1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
python-args-0.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.