Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1353102

Summary:	[RFE][CodeChange] Translations should be verified automatically
Product:	[oVirt] ovirt-engine-dashboard	Reporter:	Yedidyah Bar David <didi>
Component:	Build	Assignee:	Scott Dickerson <sdickers>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Scott Dickerson <sdickers>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	bugs, lsvaty, mgoldboi, oourfali, pstehlik, sdickers, vszocs, ykatabam, ylavi
Target Milestone:	ovirt-4.2.0	Keywords:	CodeChange, FutureFeature
Target Release:	1.2.0	Flags:	rule-engine: ovirt-4.2+ lsvaty: testing_plan_complete- mgoldboi: planning_ack+ oourfali: devel_ack+ gklein: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 10:42:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2016-07-06 06:16:39 UTC

Description of problem:

The script automation/check-patch.sh should be enhanced to prevent cases such as bug 1348695 comment 3 - fix is in [1]. It should verify that placeholders in strings are kept unchanged in their translations.

[1] https://gerrit.ovirt.org/#/q/Ied7e83f5b2e8bb029c09e69cfafb6fcb84f91732,n,z

Comment 1 Vojtech Szocs 2016-07-15 14:53:22 UTC

Thanks for pointing this out.

I think we should do translations check after linting code and before running unit tests, so it should be part of `npm test`.

Comment 8 Sandro Bonazzola 2017-12-20 10:42:35 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.