Bug 1353102 - [RFE][CodeChange] Translations should be verified automatically
Summary: [RFE][CodeChange] Translations should be verified automatically
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dashboard
Classification: oVirt
Component: Build
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.2.0
: 1.2.0
Assignee: Scott Dickerson
QA Contact: Scott Dickerson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-06 06:16 UTC by Yedidyah Bar David
Modified: 2019-04-28 13:08 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:42:35 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.2+
lsvaty: testing_plan_complete-
mgoldboi: planning_ack+
oourfali: devel_ack+
gklein: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 72620 0 master MERGED Verify translation messages and arguments 2017-03-31 14:49:38 UTC

Description Yedidyah Bar David 2016-07-06 06:16:39 UTC 
Description of problem:

The script automation/check-patch.sh should be enhanced to prevent cases such as bug 1348695 comment 3 - fix is in [1]. It should verify that placeholders in strings are kept unchanged in their translations.

[1] https://gerrit.ovirt.org/#/q/Ied7e83f5b2e8bb029c09e69cfafb6fcb84f91732,n,z
Comment 1 Vojtech Szocs 2016-07-15 14:53:22 UTC 
Thanks for pointing this out.

I think we should do translations check after linting code and before running unit tests, so it should be part of `npm test`.
Comment 8 Sandro Bonazzola 2017-12-20 10:42:35 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.