Red Hat Bugzilla – Bug 135356
disable backspace_deletes_character for hangul and hiragana
Last modified: 2007-11-30 17:10:51 EST
Description of problem:
Currently because of the backport of this feature, korean and japanese
users may not be so familiar with current behavior with current input.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
2. gedit UTF-8.txt
3. go to hangul or hiragana end char and press backspace
delete the whole character
Please see bug 132189
Upstreamed as http://bugzilla.gnome.org/show_bug.cgi?id=155897.
pango-1.6.0-6 (now building) should fix. Testing appreciated.
I have upgraded pango, re-run application and used the steps again and
I still able to delete indivi. Jamo on Hangul and delete the syllable
in hiragana. any ideas?
Blech! Turns out that the GTK+ patches are flawed.
- GtkTextView doesn't check the backspace_deletes_charactre
flag at all
- GtkEntry checks the flag on the wrong character
Created attachment 105494 [details]
Patch fixing both GTK+ bugs
I'm attaching a patch against GTK+ HEAD that fixes both problems.
I had to move the backspace logic into gtktextbuffer.c since it
needed API that GtkTextView isn't supposed to use. (GtkTextView
is supposed to work from only GtkTextBuffer public API)
If lucky it should probably apply against the GTK+-2.4 backports
as well, though it would be nice to regendiff to get a merge,
and probably also good to rename gtk_text_buffer_backspace()
to _gtk_text_buffer_backspace() for the backport. (Hmm, I think
I forgot to makes a header file addition for the new function
in this patch)
To get things working fully also requires the Pango patch in
I can't get my VPN working now, so I'll look at building fixed
packages in the morning.
Created attachment 105514 [details]
Smaller GTK+ fix
Here's a smaller patch to the same effect as the above. It's not kosher
for upstream because of the use of GtkTextBuffer private functions in
gtktextview but should be fine for the backport.
pango-1.6.0-7 has the Pango patch
gtk+-2.4.13-2 has the GTK+ patch
I've tested bits of this locally pretty thoroughly and everything
seems to work well. But additional testing still appreciated.
Confirmed fixed. Tested with pango-1.6.0-7 and gtk2-2.4.13-2.