Bug 1353598 - Review Request: hibernate4 - Relational persistence and query service
Summary: Review Request: hibernate4 - Relational persistence and query service
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1353572 1353887
Blocks: 1181081
TreeView+ depends on / blocked
 
Reported: 2016-07-07 14:18 UTC by gil cattaneo
Modified: 2016-08-29 16:24 UTC (History)
2 users (show)

Fixed In Version: hibernate4-4.3.11-1.fc25, hibernate4-4.3.11-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-04 09:30:23 UTC
Type: ---
Embargoed:
loganjerry: fedora-review+


Attachments (Terms of Use)

Description gil cattaneo 2016-07-07 14:18:34 UTC
Spec URL: https://gil.fedorapeople.org/hibernate4.spec
SRPM URL: https://gil.fedorapeople.org/hibernate4-4.3.11-1.fc23.src.rpm
Description:
Hibernate is a powerful, ultra-high performance
object/relational persistence and query service
for Java. Hibernate lets you develop persistent
objects following common Java idiom - including
association, inheritance, polymorphism, composition
and the Java collections framework. Extremely
fine-grained, richly typed object models are
possible. The Hibernate Query Language, designed
as a "minimal" object-oriented extension to SQL,
provides an elegant bridge between the object and
relational worlds. Hibernate is now the most
popular ORM solution for Java.
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14807624

Wildfly 10+ Build/Requires

Comment 1 gil cattaneo 2016-07-08 14:27:48 UTC
- added hibernate-commons-annotations-5.0.1.Final support

Comment 2 Jerry James 2016-07-15 16:54:05 UTC
I will take this review.

Comment 3 Jerry James 2016-07-15 18:10:12 UTC
How is this related to the existing hibernate package?

Comment 4 gil cattaneo 2016-07-15 18:18:59 UTC
(In reply to Jerry James from comment #3)
> How is this related to the existing hibernate package?

the packet is for Wildfly 10+, which use both 4.x and 5.x series.
and this become a compat package for provides support for whose packets which do not support the 5.x releases

for now i should comment the execution of the PATCH1, before run a build, untill
hibernate-commons-annotations will not upgraded to 5.0.1

Comment 5 gil cattaneo 2016-07-15 18:23:39 UTC
see https://fedoraproject.org/wiki/WildFly

Comment 6 Jerry James 2016-07-15 19:04:42 UTC
(In reply to gil cattaneo from comment #4)
> for now i should comment the execution of the PATCH1, before run a build,
> untill
> hibernate-commons-annotations will not upgraded to 5.0.1

Yes, the build fails otherwise.

(In reply to gil cattaneo from comment #5)
> see https://fedoraproject.org/wiki/WildFly

Wow, that's quite the project.  I wish you the best of luck in moving this forward.

Comment 7 Jerry James 2016-07-15 19:05:35 UTC
Issues
======
- Multiple licensing issues must be explained with a comment in the spec file.
  For some ideas on how this might be done, see

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

- The portions of the code with the Apache license have JBoss copyright notices.
  Is this bundled code?

- There are some file copies without -p, for SOURCE1 through SOURCE10.  Perhaps
  -p should be added to preserve timestamps.

- Could you ask upstream to update lgpl.txt to a version with the correct FSF
  address?  Version 2.1 is available here:
  http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 368640 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     hibernate4-core , hibernate4-c3p0 , hibernate4-ehcache ,
     hibernate4-entitymanager , hibernate4-envers , hibernate4-hikaricp ,
     hibernate4-infinispan , hibernate4-parent , hibernate4-proxool ,
     hibernate4-osgi , hibernate4-testing , hibernate4-javadoc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: hibernate4-core-4.3.11-1.fc25.noarch.rpm
          hibernate4-c3p0-4.3.11-1.fc25.noarch.rpm
          hibernate4-ehcache-4.3.11-1.fc25.noarch.rpm
          hibernate4-entitymanager-4.3.11-1.fc25.noarch.rpm
          hibernate4-envers-4.3.11-1.fc25.noarch.rpm
          hibernate4-hikaricp-4.3.11-1.fc25.noarch.rpm
          hibernate4-infinispan-4.3.11-1.fc25.noarch.rpm
          hibernate4-parent-4.3.11-1.fc25.noarch.rpm
          hibernate4-proxool-4.3.11-1.fc25.noarch.rpm
          hibernate4-osgi-4.3.11-1.fc25.noarch.rpm
          hibernate4-testing-4.3.11-1.fc25.noarch.rpm
          hibernate4-javadoc-4.3.11-1.fc25.noarch.rpm
          hibernate4-4.3.11-1.fc25.src.rpm
hibernate4-core.noarch: E: incorrect-fsf-address /usr/share/licenses/hibernate4-core/lgpl.txt
hibernate4-c3p0.noarch: W: no-documentation
hibernate4-ehcache.noarch: W: no-documentation
hibernate4-entitymanager.noarch: W: no-documentation
hibernate4-envers.noarch: W: no-documentation
hibernate4-hikaricp.noarch: W: no-documentation
hibernate4-infinispan.noarch: W: no-documentation
hibernate4-parent.noarch: W: no-documentation
hibernate4-parent.noarch: E: incorrect-fsf-address /usr/share/licenses/hibernate4-parent/lgpl.txt
hibernate4-proxool.noarch: W: no-documentation
hibernate4-osgi.noarch: W: no-documentation
hibernate4-testing.noarch: W: no-documentation
hibernate4-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/hibernate4-javadoc/lgpl.txt
hibernate4.src: W: spelling-error %description -l en_US polymorphism -> polymorphic, polymorphous
13 packages and 0 specfiles checked; 3 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
hibernate4-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/hibernate4-javadoc/lgpl.txt
hibernate4-hikaricp.noarch: W: no-documentation
hibernate4-entitymanager.noarch: W: no-documentation
hibernate4-c3p0.noarch: W: no-documentation
hibernate4-proxool.noarch: W: no-documentation
hibernate4-parent.noarch: W: no-documentation
hibernate4-parent.noarch: E: incorrect-fsf-address /usr/share/licenses/hibernate4-parent/lgpl.txt
hibernate4-testing.noarch: W: no-documentation
hibernate4-ehcache.noarch: W: no-documentation
hibernate4-core.noarch: E: incorrect-fsf-address /usr/share/licenses/hibernate4-core/lgpl.txt
hibernate4-osgi.noarch: W: no-documentation
hibernate4-envers.noarch: W: no-documentation
hibernate4-infinispan.noarch: W: no-documentation
12 packages and 0 specfiles checked; 3 errors, 10 warnings.



Requires
--------
hibernate4-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools

hibernate4-hikaricp (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(com.zaxxer:HikariCP)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)

hibernate4-entitymanager (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(dom4j:dom4j)
    mvn(javax.enterprise:cdi-api)
    mvn(org.hibernate.common:hibernate-commons-annotations)
    mvn(org.hibernate.javax.persistence:hibernate-jpa-2.1-api)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.javassist:javassist)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)
    mvn(org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec)

hibernate4-c3p0 (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(com.mchange:c3p0)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)

hibernate4-proxool (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)
    mvn(proxool:proxool)

hibernate4-parent (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools

hibernate4-testing (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(com.experlog:xapool)
    mvn(junit:junit)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.jboss.byteman:byteman)
    mvn(org.jboss.byteman:byteman-bmunit)
    mvn(org.jboss.byteman:byteman-install)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)
    mvn(org.jboss.narayana.jta:jta)

hibernate4-ehcache (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(net.sf.ehcache:ehcache-core)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)

hibernate4-core (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(antlr:antlr)
    mvn(com.fasterxml:classmate)
    mvn(dom4j:dom4j)
    mvn(javax.validation:validation-api)
    mvn(org.hibernate.common:hibernate-commons-annotations)
    mvn(org.hibernate.javax.persistence:hibernate-jpa-2.1-api)
    mvn(org.javassist:javassist)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)
    mvn(org.jboss.spec.javax.security.jacc:jboss-jacc-api_1.4_spec)
    mvn(org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec)
    mvn(org.jboss:jandex)

hibernate4-osgi (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.eclipse.osgi:org.eclipse.osgi)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.hibernate:hibernate-entitymanager:4.3.11.Final)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)

hibernate4-envers (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.hibernate:hibernate-entitymanager:4.3.11.Final)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)

hibernate4-infinispan (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.infinispan:infinispan-core)
    mvn(org.jboss.logging:jboss-logging)
    mvn(org.jboss.logging:jboss-logging-annotations)
    mvn(org.rhq.helpers:rhq-pluginAnnotations)



Provides
--------
hibernate4-javadoc:
    hibernate4-javadoc

hibernate4-hikaricp:
    hibernate4-hikaricp
    mvn(org.hibernate:hibernate-hikaricp:4)
    mvn(org.hibernate:hibernate-hikaricp:4.3.11)
    mvn(org.hibernate:hibernate-hikaricp:4.3.11.Final)
    mvn(org.hibernate:hibernate-hikaricp:pom:4)
    mvn(org.hibernate:hibernate-hikaricp:pom:4.3.11)
    mvn(org.hibernate:hibernate-hikaricp:pom:4.3.11.Final)
    osgi(org.hibernate.hikaricp)

hibernate4-entitymanager:
    hibernate4-entitymanager
    mvn(org.hibernate:hibernate-entitymanager:4)
    mvn(org.hibernate:hibernate-entitymanager:4.3.11)
    mvn(org.hibernate:hibernate-entitymanager:4.3.11.Final)
    mvn(org.hibernate:hibernate-entitymanager:pom:4)
    mvn(org.hibernate:hibernate-entitymanager:pom:4.3.11)
    mvn(org.hibernate:hibernate-entitymanager:pom:4.3.11.Final)
    osgi(org.hibernate.entitymanager)

hibernate4-c3p0:
    hibernate4-c3p0
    mvn(org.hibernate:hibernate-c3p0:4)
    mvn(org.hibernate:hibernate-c3p0:4.3.11)
    mvn(org.hibernate:hibernate-c3p0:4.3.11.Final)
    mvn(org.hibernate:hibernate-c3p0:pom:4)
    mvn(org.hibernate:hibernate-c3p0:pom:4.3.11)
    mvn(org.hibernate:hibernate-c3p0:pom:4.3.11.Final)
    osgi(org.hibernate.c3p0)

hibernate4-proxool:
    hibernate4-proxool
    mvn(org.hibernate:hibernate-proxool:4)
    mvn(org.hibernate:hibernate-proxool:4.3.11)
    mvn(org.hibernate:hibernate-proxool:4.3.11.Final)
    mvn(org.hibernate:hibernate-proxool:pom:4)
    mvn(org.hibernate:hibernate-proxool:pom:4.3.11)
    mvn(org.hibernate:hibernate-proxool:pom:4.3.11.Final)
    osgi(org.hibernate.proxool)

hibernate4-parent:
    hibernate4-parent
    mvn(org.hibernate:hibernate-parent:pom:4)
    mvn(org.hibernate:hibernate-parent:pom:4.3.11)
    mvn(org.hibernate:hibernate-parent:pom:4.3.11.Final)

hibernate4-testing:
    hibernate4-testing
    mvn(org.hibernate:hibernate-testing:4)
    mvn(org.hibernate:hibernate-testing:4.3.11)
    mvn(org.hibernate:hibernate-testing:4.3.11.Final)
    mvn(org.hibernate:hibernate-testing:pom:4)
    mvn(org.hibernate:hibernate-testing:pom:4.3.11)
    mvn(org.hibernate:hibernate-testing:pom:4.3.11.Final)
    osgi(org.hibernate.testing)

hibernate4-ehcache:
    hibernate4-ehcache
    mvn(org.hibernate:hibernate-ehcache:4)
    mvn(org.hibernate:hibernate-ehcache:4.3.11)
    mvn(org.hibernate:hibernate-ehcache:4.3.11.Final)
    mvn(org.hibernate:hibernate-ehcache:pom:4)
    mvn(org.hibernate:hibernate-ehcache:pom:4.3.11)
    mvn(org.hibernate:hibernate-ehcache:pom:4.3.11.Final)
    osgi(org.hibernate.ehcache)

hibernate4-core:
    hibernate4-core
    mvn(org.hibernate:hibernate-core:4)
    mvn(org.hibernate:hibernate-core:4.3.11)
    mvn(org.hibernate:hibernate-core:4.3.11.Final)
    mvn(org.hibernate:hibernate-core:pom:4)
    mvn(org.hibernate:hibernate-core:pom:4.3.11)
    mvn(org.hibernate:hibernate-core:pom:4.3.11.Final)
    osgi(org.hibernate.core)

hibernate4-osgi:
    hibernate4-osgi
    mvn(org.hibernate:hibernate-osgi:4)
    mvn(org.hibernate:hibernate-osgi:4.3.11)
    mvn(org.hibernate:hibernate-osgi:4.3.11.Final)
    mvn(org.hibernate:hibernate-osgi:pom:4)
    mvn(org.hibernate:hibernate-osgi:pom:4.3.11)
    mvn(org.hibernate:hibernate-osgi:pom:4.3.11.Final)
    osgi(org.hibernate.osgi)

hibernate4-envers:
    hibernate4-envers
    mvn(org.hibernate:hibernate-envers:4)
    mvn(org.hibernate:hibernate-envers:4.3.11)
    mvn(org.hibernate:hibernate-envers:4.3.11.Final)
    mvn(org.hibernate:hibernate-envers:pom:4)
    mvn(org.hibernate:hibernate-envers:pom:4.3.11)
    mvn(org.hibernate:hibernate-envers:pom:4.3.11.Final)
    osgi(org.hibernate.envers)

hibernate4-infinispan:
    hibernate4-infinispan
    mvn(org.hibernate:hibernate-infinispan:4)
    mvn(org.hibernate:hibernate-infinispan:4.3.11)
    mvn(org.hibernate:hibernate-infinispan:4.3.11.Final)
    mvn(org.hibernate:hibernate-infinispan:pom:4)
    mvn(org.hibernate:hibernate-infinispan:pom:4.3.11)
    mvn(org.hibernate:hibernate-infinispan:pom:4.3.11.Final)
    osgi(org.hibernate.infinispan)



Source checksums
----------------
http://www.apache.org/licenses/LICENSE-2.0.txt :
  CHECKSUM(SHA256) this package     : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30
  CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30
http://repo1.maven.org/maven2/org/hibernate/hibernate-osgi/4.3.11.Final/hibernate-osgi-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : 8bec9dce52f958a43018332b0fabfba7387a532055760e3c9a2da73144a824fa
  CHECKSUM(SHA256) upstream package : 8bec9dce52f958a43018332b0fabfba7387a532055760e3c9a2da73144a824fa
http://repo1.maven.org/maven2/org/hibernate/hibernate-core/4.3.11.Final/hibernate-core-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : 479bd4da1daeb2fecf2aae0148548855bab0289eb13dd52342ac247a076a546d
  CHECKSUM(SHA256) upstream package : 479bd4da1daeb2fecf2aae0148548855bab0289eb13dd52342ac247a076a546d
http://repo1.maven.org/maven2/org/hibernate/hibernate-ehcache/4.3.11.Final/hibernate-ehcache-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : a1465f0e8e0b197380401549de1a3168d455f9011e5f510a74d5558a8dc7da01
  CHECKSUM(SHA256) upstream package : a1465f0e8e0b197380401549de1a3168d455f9011e5f510a74d5558a8dc7da01
https://github.com/hibernate/hibernate-orm/archive/4.3.11.Final/hibernate-4.3.11.Final.tar.gz :
  CHECKSUM(SHA256) this package     : 8190d221449674f66b6c753d3207b9c78a19ba8d3fe56996332894ee9090eac3
  CHECKSUM(SHA256) upstream package : 8190d221449674f66b6c753d3207b9c78a19ba8d3fe56996332894ee9090eac3
http://repo1.maven.org/maven2/org/hibernate/hibernate-c3p0/4.3.11.Final/hibernate-c3p0-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : b08e1eabb7922827d15284c90e6e8ce5e233731f417431a55e109f3b1ace7c07
  CHECKSUM(SHA256) upstream package : b08e1eabb7922827d15284c90e6e8ce5e233731f417431a55e109f3b1ace7c07
http://repo1.maven.org/maven2/org/hibernate/hibernate-hikaricp/4.3.11.Final/hibernate-hikaricp-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : 286f5049bc5ca1cf991741966dcb2981b2599ebdb9dafba6a064ed78d9ad8efb
  CHECKSUM(SHA256) upstream package : 286f5049bc5ca1cf991741966dcb2981b2599ebdb9dafba6a064ed78d9ad8efb
http://repo1.maven.org/maven2/org/hibernate/hibernate-infinispan/4.3.11.Final/hibernate-infinispan-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : cec357ee3c49fb9d070a5095f5a1738277180f4718a865e0ea9eed2e948bafb7
  CHECKSUM(SHA256) upstream package : cec357ee3c49fb9d070a5095f5a1738277180f4718a865e0ea9eed2e948bafb7
http://repo1.maven.org/maven2/org/hibernate/hibernate-entitymanager/4.3.11.Final/hibernate-entitymanager-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : 641ff91f63e1714824fe33fd6ec0bdff243c2972c16d0514fc3af2c631b0c418
  CHECKSUM(SHA256) upstream package : 641ff91f63e1714824fe33fd6ec0bdff243c2972c16d0514fc3af2c631b0c418
http://repo1.maven.org/maven2/org/hibernate/hibernate-envers/4.3.11.Final/hibernate-envers-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : dde44479cc46df981d457db0f84ea86c382b0f855298b22122b5499e8ee0a8a2
  CHECKSUM(SHA256) upstream package : dde44479cc46df981d457db0f84ea86c382b0f855298b22122b5499e8ee0a8a2
http://repo1.maven.org/maven2/org/hibernate/hibernate-proxool/4.3.11.Final/hibernate-proxool-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : c384f12ce621126c882b32de3ec2d81055b4cc2e089bca56c0eedb7bc42e5072
  CHECKSUM(SHA256) upstream package : c384f12ce621126c882b32de3ec2d81055b4cc2e089bca56c0eedb7bc42e5072
http://repo1.maven.org/maven2/org/hibernate/hibernate-testing/4.3.11.Final/hibernate-testing-4.3.11.Final.pom :
  CHECKSUM(SHA256) this package     : 2dd09e2dface5c32d7d90ab2256be9d988bdb0f0133ab42bc6422c6414d8bf97
  CHECKSUM(SHA256) upstream package : 2dd09e2dface5c32d7d90ab2256be9d988bdb0f0133ab42bc6422c6414d8bf97


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1353598 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 8 gil cattaneo 2016-07-15 19:32:34 UTC
(In reply to Jerry James from comment #7)
> Issues
> ======
> - Multiple licensing issues must be explained with a comment in the spec
> file.
>   For some ideas on how this might be done, see
> 
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Multiple_Licensing_Scenarios
> 
> - The portions of the code with the Apache license have JBoss copyright
> notices.
>   Is this bundled code?

No, i hope, but seem all JBoss and Hibenate projects switch their license to ASL 2.0 in the near future
Please, attached the generated licensecheck.txt files is is available. so 
take a look in the source code headers ...

> - There are some file copies without -p, for SOURCE1 through SOURCE10. 
> Perhaps
>   -p should be added to preserve timestamps.

Done

> - Could you ask upstream to update lgpl.txt to a version with the correct FSF
>   address?  Version 2.1 is available here:
>   http://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt

reported @ https://hibernate.atlassian.net/browse/HHH-10961

but usually hibernate developer dont care about these problems

> Package Review
> ==============
> ===== MUST items =====

> [!]: If the package is under multiple licenses, the licensing breakdown
>      must be documented in the spec.

Some wrote above

> ===== SHOULD items =====
> 
> Generic:
> [!]: %check is present and all tests pass.
Not available test deps as commented in the spec file 
> [!]: Packages should try to preserve timestamps of original installed
>      files.
Done

Spec URL: https://gil.fedorapeople.org/hibernate4.spec
SRPM URL: https://gil.fedorapeople.org/hibernate4-4.3.11-1.fc23.src.rpm

Comment 9 Jerry James 2016-07-15 20:52:19 UTC
(In reply to gil cattaneo from comment #8)
> No, i hope, but seem all JBoss and Hibenate projects switch their license to
> ASL 2.0 in the near future
> Please, attached the generated licensecheck.txt files is is available. so 
> take a look in the source code headers ...

On second thought, let's not worry about it.  The license is clearly stated, and the files with JBoss copyrights have package names that put them firmly into the hibernate namespace, so even if they were not hibernate classes originally, they are now.  I think it's fine.  This package is APPROVED.

Comment 10 gil cattaneo 2016-07-15 21:34:14 UTC
Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/6452
https://admin.fedoraproject.org/pkgdb/package/requests/6453

Comment 11 Gwyn Ciesla 2016-07-15 21:41:22 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/hibernate4

Comment 12 gil cattaneo 2016-07-15 21:48:08 UTC
thanks!


Note You need to log in before you can comment on or make changes to this bug.