Spec URL: https://heliocastro.fedorapeople.org/qt5/qt5.spec SRPM URL: https://heliocastro.fedorapeople.org/qt5/qt5-5.7.0-5.fc24.src.rpm Description: Qt5 meta package Fedora Account System Username: heliocastro
Moving macros.qt5 from qt5-qtbase here means that packagers will have to have this package (and thus the *entire* Qt5) installed in order to do packaging work on anything that depends on Qt5. I don't like that. I would much more prefer keeping the macro files in qt5-qtbase.
Oh, I haven't noticed the rpm-macros subpackage. Please ignore my previous comment. (I blame the unbearable temperatures in my office :-))
> %files rpm-macros > %{_rpmconfigdir}/macros.d/macros.qt5 Wondering too here, why not (any more) in qt5-qtbase-devel ?
Devel on qt5-qtbase-devel requires the macro package Since everyone uses qt5-qtbase-devel it comes by default. I just wanted to follow same schema as kf5.macros.
Will review now
Approved! Stuff like macros looks fine, package is named correctly, Conflicts/Provides etc. is fine. Just one question: Maybe you want to introduce versioned dependencies? So if one installs qt5-5.7.0 all deps are forced to be Qt 5.7.0.
And of course: fedora-review does not show any obvious issues :)
sed -i \ -e "s|@@QT5_CFLAGS@@|%{?qt5_cflags}|g" \ -e "s|@@QT5_CXXFLAGS@@|%{?qt5_cxxflags}|g" \ -e "s|@@QT5_RPM_LD_FLAGS@@|%{?qt5_rpm_ld_flags}|g" \ -e "s|@@QT5_RPM_OPT_FLAGS@@|%{?qt5_rpm_opt_flags} %{?qt5_null_flag}|g" \ %{buildroot}%{_rpmconfigdir}/macros.d/macros.qt5 This won't work as-is, since the macros qt5_cflags qt5_cxxflags qt5_rpm_ld_flags qt5_rpm_opt_flags are not yet defined when this package is built.
Fixed on Spec URL: https://heliocastro.fedorapeople.org/qt5/qt5.spec SRPM URL: https://heliocastro.fedorapeople.org/qt5/qt5-5.7.0-6.fc24.src.rpm
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5