Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1355721 - The value of skipcommit cannot be shown correctly when set router loglevel=4
The value of skipcommit cannot be shown correctly when set router loglevel=4
Status: CLOSED ERRATA
Product: OpenShift Container Platform
Classification: Red Hat
Component: Routing (Show other bugs)
3.2.1
Unspecified Unspecified
medium Severity low
: ---
: ---
Assigned To: Ram Ranganathan
Meng Bo
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-07-12 06:47 EDT by Meng Bo
Modified: 2017-03-08 13 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Verbose log message fix.
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-09-27 05:39:44 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1933 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.3 Release Advisory 2016-09-27 09:24:36 EDT

  None (edit)
Description Meng Bo 2016-07-12 06:47:34 EDT
Description of problem:
Set the router log level to 4 and check the log.
The skipcommit value cannot be shown as expected in the log.

# oc logs  router-3-w0kyn  | grep skip\ commit
I0712 09:35:13.603024       1 router.go:630] Updating skip commit to: %!s(bool=true)
I0712 09:37:15.227676       1 router.go:630] Updating skip commit to: %!s(bool=false)
I0712 09:45:14.592676       1 router.go:630] Updating skip commit to: %!s(bool=true)
I0712 09:45:14.780738       1 router.go:630] Updating skip commit to: %!s(bool=false)



Version-Release number of selected component (if applicable):
openshift 3.2.1.5

How reproducible:
always

Steps to Reproduce:
1. Create router on the env
2. Change the loglevel to 4 by editing the dc
3. Check the router pod log

Actual results:
# oc logs  router-3-w0kyn  | grep skip\ commit
I0712 09:35:13.603024       1 router.go:630] Updating skip commit to: %!s(bool=true)
I0712 09:37:15.227676       1 router.go:630] Updating skip commit to: %!s(bool=false)
I0712 09:45:14.592676       1 router.go:630] Updating skip commit to: %!s(bool=true)
I0712 09:45:14.780738       1 router.go:630] Updating skip commit to: %!s(bool=false)


Expected results:
Should show the value correctly.

Additional info:
[root@master ~]# grep -in "skipcommit" src/github.com/origin/pkg/router/template/router.go 
83:     skipCommit bool
255:    if r.skipCommit {
653:// SetSkipCommit indicates to the router whether requests to
655:func (r *templateRouter) SetSkipCommit(skipCommit bool) {
656:    if r.skipCommit != skipCommit {
657:            glog.V(4).Infof("Updating skip commit to: %s", skipCommit)
658:            r.skipCommit = skipCommit
Comment 1 Ram Ranganathan 2016-08-02 17:06:46 EDT
Associated PR: https://github.com/openshift/origin/pull/9872 

@bmeng  thx
Comment 2 Troy Dawson 2016-09-01 11:14:31 EDT
This has been merged into ose and is in OSE v3.3.0.28 or newer.
Comment 4 Meng Bo 2016-09-02 01:54:33 EDT
Checked on router image openshift3/ose-haproxy-router:v3.3.0.28 6ff97e2fd698

Issue has been fixed.

I0902 01:52:49.351771       1 router.go:330] Reloading the router
I0902 01:52:49.368650       1 router.go:710] Updating skip commit to: true
Comment 6 errata-xmlrpc 2016-09-27 05:39:44 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1933

Note You need to log in before you can comment on or make changes to this bug.