Description of problem: Set the router log level to 4 and check the log. The skipcommit value cannot be shown as expected in the log. # oc logs router-3-w0kyn | grep skip\ commit I0712 09:35:13.603024 1 router.go:630] Updating skip commit to: %!s(bool=true) I0712 09:37:15.227676 1 router.go:630] Updating skip commit to: %!s(bool=false) I0712 09:45:14.592676 1 router.go:630] Updating skip commit to: %!s(bool=true) I0712 09:45:14.780738 1 router.go:630] Updating skip commit to: %!s(bool=false) Version-Release number of selected component (if applicable): openshift 3.2.1.5 How reproducible: always Steps to Reproduce: 1. Create router on the env 2. Change the loglevel to 4 by editing the dc 3. Check the router pod log Actual results: # oc logs router-3-w0kyn | grep skip\ commit I0712 09:35:13.603024 1 router.go:630] Updating skip commit to: %!s(bool=true) I0712 09:37:15.227676 1 router.go:630] Updating skip commit to: %!s(bool=false) I0712 09:45:14.592676 1 router.go:630] Updating skip commit to: %!s(bool=true) I0712 09:45:14.780738 1 router.go:630] Updating skip commit to: %!s(bool=false) Expected results: Should show the value correctly. Additional info: [root@master ~]# grep -in "skipcommit" src/github.com/origin/pkg/router/template/router.go 83: skipCommit bool 255: if r.skipCommit { 653:// SetSkipCommit indicates to the router whether requests to 655:func (r *templateRouter) SetSkipCommit(skipCommit bool) { 656: if r.skipCommit != skipCommit { 657: glog.V(4).Infof("Updating skip commit to: %s", skipCommit) 658: r.skipCommit = skipCommit
Associated PR: https://github.com/openshift/origin/pull/9872 @bmeng thx
This has been merged into ose and is in OSE v3.3.0.28 or newer.
Checked on router image openshift3/ose-haproxy-router:v3.3.0.28 6ff97e2fd698 Issue has been fixed. I0902 01:52:49.351771 1 router.go:330] Reloading the router I0902 01:52:49.368650 1 router.go:710] Updating skip commit to: true
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1933